fix: No Visual Difference on Clicking Views #1283
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RotBolt
changed the title
RotBolt
changed the title
|
Change the ripple width to match parent |
|
Umm , Actually I intentionally restrained it . As it shows There's huge blank space on right hand side . Which shouldn't show click effect |
|
It should. |
|
Ok . Will do it |
|
converted to match parent |
iamareebjamal
previously approved these changes
Mar 16, 2019
Signed-off-by: thelimitbreaker <rohanmaityofficial@gmail.com>
|
@iamareebjamal I have made requested changes . Please review and if seems proper,.merge it |
nikit19
approved these changes
Mar 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1281
Changes: [Add here what changes were made in this issue and if possible provide links.]
Add ?selectableItemBackground for making Visual Difference on Clicking them
Screenshots for the change:
