feat: Add Places AutoComplete for Search #1306

RotBolt · 2019-03-14T11:20:11Z

Fixes #799

Changes:

Add MapBox Autocomplete Place View , as it doesn't need PlayServices
So work on both F-droid and PlayStore version :)
1.1) Changes done in the layout for Better UX
1.2) Also shows Recents Location
Change in "Current Location" and change in place of Current Location
Because "Current Location button" could not come in between the AutoComplete Fragment
Added a custom Round background used in "Current Location Button"
For better and Nice UX
Change in the color of ic_location_pin and used tint to change the color where needed

Screenshots for the change:

PlayStore

F-Droid

Update : Restore ActionBar

RotBolt · 2019-03-14T11:22:15Z

@iamareebjamal Please Review

addiegupta · 2019-03-14T15:47:36Z

app/src/main/java/org/fossasia/openevent/general/search/SearchLocationFragment.kt

        when (requestCode) {
            LOCATION_PERMISSION_REQUEST -> {
                if (grantResults.isNotEmpty() && grantResults[0] == PackageManager.PERMISSION_GRANTED) {
                    geoLocationViewModel.configure()
                } else {
-                    Snackbar.make(rootView, R.string.cannot_fetch_location, Snackbar.LENGTH_SHORT).show()
+                    Snackbar.make(rootView, R.string.cannot_fetch_location, Snackbar.LENGTH_SHORT)
+                        .show()


Unnecessary change

I just ran Code Format , it did that automatically.

Don't run auto format in PRs.

Do I have to revert this change ?

ok will do it

@ShridharGoel I have removed unnecessary changes . Please merge this

iamareebjamal · 2019-03-15T11:44:42Z

Great work. Ask your peers to review it first

RotBolt · 2019-03-16T01:44:20Z

Great work. Ask your peers to review it first

Thank you. And Would take care of this thing first

Signed-off-by: thelimitbreaker <rohanmaityofficial@gmail.com>

liveHarshit

Action bar is missing in search fragment.

liveHarshit · 2019-03-20T07:05:31Z

app/src/main/java/org/fossasia/openevent/general/search/SearchLocationFragment.kt

+        inflater: LayoutInflater,
+        container: ViewGroup?,
+        savedInstanceState: Bundle?
+    ): View? {


Unnecessary changes.

Umm . This is for better view of parameters used. Still don't want . I would revert it

liveHarshit · 2019-03-20T07:09:33Z

A search bar should be there. Why you remove it?
Please check search in Eventbrite, how it works.

RotBolt · 2019-03-20T07:48:43Z

A search bar should be there. Why you remove it?
Please check search in Eventbrite, how it works.

@liveHarshit there is search bar in the fragment itself . You could see in the gif .

RotBolt · 2019-03-20T07:53:30Z

Action bar is missing in search fragment.

@liveHarshit , Autocomplete fragment itself give a back button . Having action bar for back button and fragment also showing backbutton will create UI confusion.

RotBolt · 2019-03-20T07:56:47Z

@liveHarshit eventbrite uses Google's Autocomplete which would require Play services and show the results in custom layout. I could do that . But it won't work for f-droid (because of Play services) .
Current MapBox Autocomplete works on both and provides same UI for both versions

liveHarshit · 2019-03-20T08:00:08Z

Action bar is missing in search fragment.

@liveHarshit , Autocomplete fragment itself give a back button . Having action bar for back button and fragment also showing backbutton will create UI confusion.

I'm asking about the action bar in the search fragment, not in search location fragment.

RotBolt · 2019-03-20T08:09:05Z

I'm asking about the action bar in the search fragment, not in search location fragment.

I have done no changes in SearchFragment.kt . You could see in Files Changed

liveHarshit · 2019-03-20T08:22:24Z

I'm asking about the action bar in the search fragment, not in search location fragment.

I have done no changes in SearchFragment.kt . You could see in Files Changed

One change reflects another.

liveHarshit · 2019-03-20T08:24:41Z

app/src/main/java/org/fossasia/openevent/general/search/SearchLocationFragment.kt

-            thisActivity.supportActionBar?.show()
-            thisActivity.supportActionBar?.title = ""
-            thisActivity.supportActionBar?.setDisplayHomeAsUpEnabled(true)
+            thisActivity.supportActionBar?.hide()


Here you hide it in activity, not in the fragment, so you need to show it again in search fragment.

Hmm , that for removing actionbar in SearchLocationFragment.kt.
Will have to enable the actionbar in onResume() of SearchFragment.kt
Thanks for pointing it out :) .will do it

Not onReasume, show it in onDestroyView of search location fragment.

Yeah sorry . I forgot these are fragments. Will have to call this in onDestroyView .

liveHarshit · 2019-03-20T08:25:14Z

app/src/main/java/org/fossasia/openevent/general/search/SearchLocationFragment.kt

    private fun checkLocationPermission() {
        val permission =
-            ContextCompat.checkSelfPermission(requireContext(), Manifest.permission.ACCESS_COARSE_LOCATION)
+            ContextCompat.checkSelfPermission(requireContext(),
+                Manifest.permission.ACCESS_COARSE_LOCATION)


Unnecessary changes.

liveHarshit · 2019-03-20T08:25:51Z

app/src/main/java/org/fossasia/openevent/general/search/SearchLocationFragment.kt

@@ -91,7 +81,42 @@ class SearchLocationFragment : Fragment() {
        Navigation.findNavController(rootView).popBackStack(fragmentId, false)
    }

-    override fun onRequestPermissionsResult(requestCode: Int, permissions: Array<String>, grantResults: IntArray) {


Also change override method in MainActivity.

…android into feature/autocomplete-place

RotBolt · 2019-03-21T11:19:50Z

@liveHarshit I have updated it Removed unecessary changs and actionbar is also shown

liveHarshit

Can you please update the GIF as well?

liveHarshit · 2019-03-21T12:11:48Z

app/src/main/java/org/fossasia/openevent/general/search/SearchLocationFragment.kt

@@ -31,22 +31,19 @@ class SearchLocationFragment : Fragment() {
    private val geoLocationViewModel by viewModel<GeoLocationViewModel>()
    private val safeArgs: SearchLocationFragmentArgs by navArgs()

+    private val AUTOCOMPLETE_FRAG_TAG = "AutoComplete_Frag"


Declare it as constant.

liveHarshit · 2019-03-21T12:14:21Z

Also change override method in MainActivity.

And what about it?

RotBolt · 2019-03-21T12:16:12Z

Also change override method in MainActivity.

And what about it?

I didn't change Override method then, It was syntax change, that was show,n back then . You could see in files changed

liveHarshit · 2019-03-21T12:22:58Z

Earlier you have removed onRequestPermissionsResult. It is calling from MainActivity, so I asked to change it. Now it is okay.

liveHarshit · 2019-03-21T12:32:04Z

The current location button at the bottom looks odd. Can you please add it at top of the list like google map.

RotBolt · 2019-03-21T12:36:57Z

Change in "Current Location" and change in place of Current Location
Because "Current Location button" could not come in between the AutoComplete Fragment

I mentioned this, It could not come in between, search bar and list.

Alternate way is

Use Google Autocomplete API,
get result (JSON)
Show it in custom view,
but that also would support only PlayStore only (Due to Play services issue)

F-Droid would still be left

liveHarshit · 2019-03-21T12:42:35Z

@iamareebjamal Your opinion?

iamareebjamal · 2019-03-21T13:56:09Z

Seems fine if it is not our UI. It's less code to maintain. @liveHarshit Please approve if everything else is fine

liveHarshit

LGTM

iamareebjamal · 2019-03-23T19:21:53Z

Resolve conflicts

RotBolt · 2019-03-24T19:46:32Z

@iamareebjamal , after merging latest commits. New Voice button is added . But it was added for old layout. Now for adding autoplace frag. I might again have to change the layout . Could I do that ?

RotBolt changed the title ~~Feat: Add Places AutoComplete for Search~~ feat: Add Places AutoComplete for Search Mar 14, 2019

fossasia deleted a comment Mar 14, 2019

addiegupta reviewed Mar 14, 2019

View reviewed changes

feat: Add Places AutoComplete for Search

2949185

Signed-off-by: thelimitbreaker <rohanmaityofficial@gmail.com>

liveHarshit reviewed Mar 20, 2019

View reviewed changes

Merge branch 'development' of https://github.com/fossasia/open-event-…

64fdffd

…android into feature/autocomplete-place

liveHarshit reviewed Mar 21, 2019

View reviewed changes

re-show actionBar

03e00d2

liveHarshit previously approved these changes Mar 21, 2019

View reviewed changes

iamareebjamal previously approved these changes Mar 21, 2019

View reviewed changes

nikit19 previously approved these changes Mar 23, 2019

View reviewed changes

Merge branch 'development' into feature/autocomplete-place

0010cf5

RotBolt dismissed stale reviews from nikit19, iamareebjamal, and liveHarshit via 0010cf5 March 24, 2019 18:37

iamareebjamal previously approved these changes Mar 24, 2019

View reviewed changes

resolve conflicts

5d85b9a

RotBolt dismissed iamareebjamal’s stale review via 5d85b9a March 24, 2019 19:05

iamareebjamal merged commit c22db3a into fossasia:development Mar 24, 2019

RotBolt deleted the feature/autocomplete-place branch April 5, 2019 02:37

iamareebjamal added the feature label Apr 5, 2019

feat: Add Places AutoComplete for Search #1306

feat: Add Places AutoComplete for Search #1306

Conversation

RotBolt commented Mar 14, 2019 • edited Loading

PlayStore

F-Droid

Update : Restore ActionBar

RotBolt commented Mar 14, 2019

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

iamareebjamal commented Mar 15, 2019

RotBolt commented Mar 16, 2019

liveHarshit left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

liveHarshit commented Mar 20, 2019

RotBolt commented Mar 20, 2019

RotBolt commented Mar 20, 2019

RotBolt commented Mar 20, 2019

liveHarshit commented Mar 20, 2019

RotBolt commented Mar 20, 2019

liveHarshit commented Mar 20, 2019 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

RotBolt commented Mar 21, 2019

liveHarshit left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

liveHarshit commented Mar 21, 2019

RotBolt commented Mar 21, 2019 • edited Loading

liveHarshit commented Mar 21, 2019

liveHarshit commented Mar 21, 2019

RotBolt commented Mar 21, 2019

liveHarshit commented Mar 21, 2019 • edited Loading

iamareebjamal commented Mar 21, 2019

liveHarshit left a comment

Choose a reason for hiding this comment

iamareebjamal commented Mar 23, 2019

RotBolt commented Mar 24, 2019

RotBolt commented Mar 14, 2019 •

edited

Loading

liveHarshit commented Mar 20, 2019 •

edited

Loading

RotBolt commented Mar 21, 2019 •

edited

Loading

liveHarshit commented Mar 21, 2019 •

edited

Loading