fix: EditProfile discard changes dialog shown on back press #1307

addiegupta · 2019-03-14T15:44:41Z

Fixes Issue #1292. The behaviour for up button has been replicated for the back button. So now if changes are made in the EditProfileFragment and the back button or the up button is pressed, an AlertDialog is displayed which warns the user of the unsaved changes

Changes:
The MainActivity class has been modified to handle the backPress for the EditProfileFragment. It in turn calls a method in EditProfileFragment which handles the backPress. When the back button is finally meant to be pressed from EditProfileFragment to go back, then super.onBackPressed is called using a new method.

Please suggest a better method to implement this if any.

Screenshots for the change:

iamareebjamal · 2019-03-16T03:49:12Z

The solution presented is very brittle and can fail in many ways

addiegupta · 2019-03-16T04:23:33Z

The solution presented is very brittle and can fail in many ways

Can you guide me towards an efficient solution?

iamareebjamal · 2019-03-16T04:29:55Z

Why you haven't just overriden onBackPressed in the fragment?

addiegupta · 2019-03-16T04:32:20Z

Why you haven't just overriden onBackPressed in the fragment?

As far as I checked onBackPressed cannot be overriden in fragments. That is why I took this route.

iamareebjamal · 2019-03-16T08:33:00Z

app/src/main/java/org/fossasia/openevent/general/MainActivity.kt

+     * Called by EditProfileFragment to go to previous fragment
+     */
+    fun onSuperBackPressed() {
+        super.onBackPressed()


Useless as it's just calling onBackPressed. OnBackPressed can be called directly

I use this method to call the direct onBackPressed from the EditProfileFragment. If i would have called the onBackPressed then it would have called the overriden method which would again call the handleBackPress() method causing a cycle

Any changes I should make?

addiegupta · 2019-03-17T12:05:31Z

@iamareebjamal I have updated the branch. Please review

liveHarshit

You need to check if edit text and image field are clicked, then only show an alert dialog.

liveHarshit · 2019-03-19T15:33:21Z

app/src/main/java/org/fossasia/openevent/general/MainActivity.kt

+
+                // Calls the handleBackPress method in EditProfileFragment
+                val hostFragment = supportFragmentManager.findFragmentById(R.id.frameContainer) as? NavHostFragment
+                (hostFragment?.childFragmentManager?.fragments?.get(0) as? EditProfileFragment)?.handleBackPress()


Too complex.

Should I split these up into more lines of code or do you mean some other way should be used? Because I could not find any other way

You just need to call the method in edit profile fragment. Can't you do it by taking the fragment as object?

How do I get a reference to the Fragment instance? It is done using FragmentManager only right? If I used any other method to obtain the fragment the app was crashing

liveHarshit · 2019-03-19T15:33:32Z

app/src/main/java/org/fossasia/openevent/general/auth/EditProfileFragment.kt

@@ -110,7 +111,7 @@ class EditProfileFragment : Fragment() {
            .observe(this, Observer {
                Snackbar.make(rootView.editProfileCoordinatorLayout, it, Snackbar.LENGTH_LONG).show()
                if (it == USER_UPDATED) {
-                    activity?.onBackPressed()
+                    (activity as? MainActivity)?.onSuperBackPressed()


Do not cast.

How do I use this method from MainActivity then without casting?

Use smart cast instead.

Changes made

addiegupta · 2019-03-19T16:36:36Z

You need to check if edit text and image field are clicked, then only show an alert dialog.

This is done in the following code

if (!avatarUpdated && rootView.lastName.text.toString() == userLastName && rootView.firstName.text.toString() == userFirstName)

addiegupta · 2019-03-22T10:47:47Z

app/src/main/java/org/fossasia/openevent/general/auth/EditProfileFragment.kt

@@ -110,7 +111,7 @@ class EditProfileFragment : Fragment() {
            .observe(this, Observer {
                Snackbar.make(rootView.editProfileCoordinatorLayout, it, Snackbar.LENGTH_LONG).show()
                if (it == USER_UPDATED) {
-                    activity?.onBackPressed()
+                    activity?.let { act -> if (act is MainActivity) act.onSuperBackPressed() }
                }


@liveHarshit I have done it this way instead of using if(activity is MainActivity) activity.onSuperBackPressed() because the following error occurred for this method

Smart cast to 'MainActivity' is impossible, because 'activity' is a property that has open or custom getter

Using let worked

Then use a value - val thisActivity = activity then cast for thisActivity.

okay! I tried that also but thought this was cleaner. will implement this

liveHarshit · 2019-03-22T12:03:36Z

app/src/main/java/org/fossasia/openevent/general/auth/EditProfileFragment.kt

+     * Handles back press when up button or back button is pressed
+     */
+    fun handleBackPress() {
+        val activity = activity as? MainActivity


Don't cast like that.

addiegupta · 2019-03-23T06:35:57Z

@iamareebjamal @liveHarshit any other changes that I should make in this?

Fixes Issue fossasia#1292. The behaviour for up button has been replicated for the back button. So now if changes are made in the EditProfileFragment and the back button or the up button is pressed, an AlertDialog is displayed which warns the user of the unsaved changes

liveHarshit · 2019-03-23T15:05:19Z

@iamareebjamal Please review.

iamareebjamal

This is very hacky. Features which require such hacky code are generally not worth it

addiegupta force-pushed the #1292 branch 2 times, most recently from 7c1e320 to 8a80e79 Compare March 15, 2019 04:37

fossasia deleted a comment Mar 15, 2019

addiegupta force-pushed the #1292 branch 3 times, most recently from bb97b30 to fe24593 Compare March 15, 2019 11:42

iamareebjamal requested changes Mar 16, 2019

View reviewed changes

addiegupta force-pushed the #1292 branch from fe24593 to 02c9b61 Compare March 17, 2019 11:33

liveHarshit reviewed Mar 19, 2019

View reviewed changes

addiegupta force-pushed the #1292 branch from 02c9b61 to 6a55cf8 Compare March 22, 2019 10:45

addiegupta commented Mar 22, 2019

View reviewed changes

addiegupta force-pushed the #1292 branch from 6a55cf8 to c878b36 Compare March 22, 2019 10:49

liveHarshit reviewed Mar 22, 2019

View reviewed changes

addiegupta force-pushed the #1292 branch 2 times, most recently from 83ecebe to d67fbae Compare March 22, 2019 12:13

addiegupta force-pushed the #1292 branch from d67fbae to 465ff05 Compare March 23, 2019 07:01

iamareebjamal approved these changes Mar 23, 2019

View reviewed changes

nikit19 approved these changes Mar 23, 2019

View reviewed changes

Merge branch 'development' into fossasia#1292

bc2a2ad

Merge branch 'development' into fossasia#1292

1eef2b5

iamareebjamal merged commit 8fc9af5 into fossasia:development Mar 23, 2019

addiegupta deleted the #1292 branch March 24, 2019 05:26

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: EditProfile discard changes dialog shown on back press #1307

fix: EditProfile discard changes dialog shown on back press #1307

addiegupta commented Mar 14, 2019

iamareebjamal commented Mar 16, 2019

addiegupta commented Mar 16, 2019

iamareebjamal commented Mar 16, 2019

addiegupta commented Mar 16, 2019

iamareebjamal Mar 16, 2019

addiegupta Mar 16, 2019 •

edited

Loading

iamareebjamal Mar 16, 2019

addiegupta Mar 16, 2019

addiegupta commented Mar 17, 2019

liveHarshit left a comment

liveHarshit Mar 19, 2019

addiegupta Mar 19, 2019

liveHarshit Mar 22, 2019

addiegupta Mar 22, 2019 •

edited

Loading

liveHarshit Mar 19, 2019

addiegupta Mar 19, 2019

liveHarshit Mar 19, 2019

addiegupta Mar 22, 2019

addiegupta commented Mar 19, 2019

addiegupta Mar 22, 2019 •

edited

Loading

liveHarshit Mar 22, 2019

addiegupta Mar 22, 2019

liveHarshit Mar 22, 2019

addiegupta Mar 22, 2019

addiegupta commented Mar 23, 2019

liveHarshit commented Mar 23, 2019

iamareebjamal left a comment

fix: EditProfile discard changes dialog shown on back press #1307

fix: EditProfile discard changes dialog shown on back press #1307

Conversation

addiegupta commented Mar 14, 2019

iamareebjamal commented Mar 16, 2019

addiegupta commented Mar 16, 2019

iamareebjamal commented Mar 16, 2019

addiegupta commented Mar 16, 2019

Choose a reason for hiding this comment

addiegupta Mar 16, 2019 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

addiegupta commented Mar 17, 2019

liveHarshit left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

addiegupta Mar 22, 2019 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

addiegupta commented Mar 19, 2019

addiegupta Mar 22, 2019 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

addiegupta commented Mar 23, 2019

liveHarshit commented Mar 23, 2019

iamareebjamal left a comment

Choose a reason for hiding this comment

addiegupta Mar 16, 2019 •

edited

Loading

addiegupta Mar 22, 2019 •

edited

Loading

addiegupta Mar 22, 2019 •

edited

Loading