fix: Empty organizer section in Ticket Details (#1308) #1309
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
No wildcard imports |
iamanbansal
force-pushed
the
organizer_label
branch
2 times, most recently
from
1142e70 to
88ecb52
Compare
ShridharGoel
suggested changes
Mar 17, 2019
| import kotlinx.android.synthetic.main.item_card_order_details.view.orderIdentifier | ||
| import kotlinx.android.synthetic.main.item_card_order_details.view.organizer |
There was a problem hiding this comment.
All the above are unnecessary changes.
There was a problem hiding this comment.
IDE itself made wildcard import, so I manually did all imports
There was a problem hiding this comment.
That's okay, but then you can put them in the same way they were earlier to prevent these deletions and additions from showing up.
There was a problem hiding this comment.
I will keep in mind next time :)
removed wildcard import, please review @iamareebjamal |
liveHarshit
reviewed
Mar 20, 2019
iamanbansal
force-pushed
the
organizer_label
branch
from
88ecb52 to
fe2838d
Compare
done :) |
liveHarshit
approved these changes
Mar 20, 2019
iamareebjamal
approved these changes
Mar 20, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1308
Changes: hide organizer label when there is no information about the organizer
Screenshots for the change:
