-
Notifications
You must be signed in to change notification settings - Fork 551
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: room dependency causing build fail #1324
Conversation
Why are there so many other changes in the |
So that Travis build passes |
|
i first pushed a commit. Travis build failed. Then made the string changes, squashed the commits and then made a force push |
|
Yes i did try without the string changes |
@iamareebjamal Can you please review this and merge if everything looks good? I want to work on the List Adapter PR but if I commit without these changes then the build will fail again. |
I actually listed the reason for updating the strings on point 3. But I'll make it more clearer. Thanks! |
@addiegupta My apologies, I did not spot the description when I read this PR for some reason. It will be great if this PR is merged. Other PRs development can finally continue after this. |
I don't think the build will fail without the string changes. It'll just throw a warning. However, since this is much needed PR, I'll approve. Create a new PR reverting the changes and let's see if it fails |
@iamareebjamal okay sure! |
Fixes Issue fossasia#1329 . PR fossasia#1324 was merged as it was a required PR but it had some additional unwanted changes which were made so that the Travis build passes. This PR aims to revert these changes and check the status of Travis build
Fixes Issue fossasia#1329 . PR fossasia#1324 was merged as it was a required PR but it had some additional unwanted changes which were made so that the Travis build passes. This PR aims to revert these changes and check the status of Travis build
Fixes #1323
Changes:
to version "2.1.0-alpha04"
EDIT:- Changes made on second commit after Travis build failed on first commit
3) Added the
translatable = "false"
property to strings that do not have their translations yet so that the Travis build succeeds. When all of their translations have been added, this property can be removed.The build is now successful