feat: Implemented Voice Search #1358
Conversation
|
@nikit19 @iamareebjamal please help |
|
There is a wildcard import in one of you files which is causing the Travis build fail |
|
@aggarwalpulkit596 Can you suggest a way to fix it? |
|
Just remove any generic import ending with .* |
|
Build is failing due to format violations |
|
@ShridharGoel I had carefully refactored the code in android studio before pushing to github... Can you suggest a way to fix the error? |
Run this command 'gradlew spotlessApply' to fix the error |
|
Also, the UI needs to be better. No need to write 'Use Voice Search' just the icon is sufficient and that icon should be at the right end of the 'Enter a location' field, this is what I would suggest. |
|
@iamareebjamal @nikit19 please review |
|
UI is looking really bad. Take a look at existing apps which use voice search |
|
Still, do you seriously think it looks good? |
|
How about this? |
|
Just check voice search in play store and other applications. |
|
@liveHarshit please see this:- |
app/src/main/java/org/fossasia/openevent/general/search/SearchLocationFragment.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/org/fossasia/openevent/general/search/SearchLocationFragment.kt
Outdated
Show resolved
Hide resolved
|
@iamareebjamal Used vector icon. PR is updated |
|
@iamareebjamal Any other changes required? |
|
@iamareebjamal I think this PR is ready. |
|
As told before, ask peer review first |
|
@liveHarshit What's your opinion? |
| @@ -26,6 +27,6 @@ | |||
| </activity> | |||
| <meta-data | |||
| android:name="com.stripe.android.API_KEY" | |||
| android:value="${STRIPE_API_TOKEN}"/> | |||
| android:value="${STRIPE_API_TOKEN}" /> | |||
There was a problem hiding this comment.
Since I've added RECORD_AUDIO permission in manifest, everyline went down by one.
I've checked it in my IDE.
In mine, last line is line30.
No extra space is there.
app/src/main/java/org/fossasia/openevent/general/search/SearchLocationFragment.kt
Outdated
Show resolved
Hide resolved
|
@liveHarshit I'll make necessary changes and update accordingly. |
|
@liveHarshit PR is updated |
app/src/main/java/org/fossasia/openevent/general/search/SearchLocationFragment.kt
Show resolved
Hide resolved
|
@liveHarshit please see the code now |
|
@iamareebjamal please review |
This reverts commit 5b797ae.
Fixes #1357
Changes: Voice Search is used.
proper permission is taken.
It is a necessary feature.
Screenshots for the change: