fix: Content for Error fetching event (#1366) #1375
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Resolve conflicts |
iamanbansal
force-pushed
the
detailserror
branch
2 times, most recently
from
3265117 to
453fbe9
Compare
done. |
liveHarshit
reviewed
Mar 22, 2019
| } |
iamanbansal
force-pushed
the
detailserror
branch
from
453fbe9 to
2189e15
Compare
|
@iamareebjamal @liveHarshit what's wrong with Semantic? |
|
@aman210697 Try adding a space after the colon in title |
iamanbansal
changed the title
|
@liveHarshit please review |
|
Remove snackbar message |
iamanbansal
force-pushed
the
detailserror
branch
2 times, most recently
from
6e47b8e to
ca501c2
Compare
|
|
What happens when you click favorite or share button? |
crash 😄 |
iamanbansal
force-pushed
the
detailserror
branch
from
ca501c2 to
191533c
Compare
Then solve the issue properly. |
iamanbansal
force-pushed
the
detailserror
branch
from
191533c to
fba97a0
Compare
looks good? |
liveHarshit
approved these changes
Mar 25, 2019
iamareebjamal
approved these changes
Mar 25, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1366
Changes: new layout file for error on fetching event
Screenshots for the change:
