feat: Navigation icon clicked scroll to top #1391
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@iamareebjamal please review |
|
Ask for peer reviews first, please |
|
@iamareebjamal Oh sorry |
| @@ -208,4 +209,6 @@ class EventsFragment : Fragment() { | |||
| rootView.swiperefresh?.setOnRefreshListener(null) | |||
| super.onStop() | |||
| } | |||
|
|
|||
| fun scrollToTop() = rootView.eventsNestedScrollView.smoothScrollTo(1, 1) | |||
There was a problem hiding this comment.
Create an interface with this function
| val hostFragment = supportFragmentManager.findFragmentById(R.id.frameContainer) | ||
| if (hostFragment is NavHostFragment) { | ||
| val currentFragment = hostFragment.childFragmentManager.fragments.first() | ||
| when (item.itemId) { |
There was a problem hiding this comment.
Just check if the fragment is implementing the interface and call the function
There was a problem hiding this comment.
I have followed your guidelines and made the changes
Details: ScrollToTop interface is created so that appropriate fragments will implement. In the MainActivity, bottom navigation callback on actionReselectedListener is called to handle scroll link to the top of the current fragment (EventsFragment and OrdersUnderUserFragment) Fixes #1387
iamareebjamal
approved these changes
Mar 27, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details:
Fixes #1387
Screenshots for the change:
