fix: app crash due to IllegalArgumentException in SearchFragment #1394
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes:fossasia#1383 - A default value of 'null' has been assigned to the argument 'saved_date'. - This resolves the crash as the SearchFragmentArgs generated files throws an IllegalArgumentException if this argument does not exist in the bundle with which it is initialsed in its 'fromBundle' method. Now a null value is passed and hence the crash does not occur. - Additionally 2 hardcoded strings have been replaced with their resource reference equivalents
addiegupta
commented
Mar 24, 2019
| @@ -105,7 +105,7 @@ class SearchTimeFragment : Fragment() { | |||
| } | |||
|
|
|||
| private fun redirectToSearch(time: String) { | |||
| val args = SearchFragmentArgs.Builder(time).build().toBundle() | |||
| val args = SearchFragmentArgs.Builder().setStringSavedDate(time).build().toBundle() | |||
There was a problem hiding this comment.
I made this change because for some reason that I could not find, the constructor for SearchFragmentArgs.Builder that takes a string as an argument appears to be missing from the generated file of SearchFragmentArgs.java
This is the missing constructor:
public Builder(@Nullable String StringSavedDate) { this.arguments.put("@string/saved_date", StringSavedDate); }
iamareebjamal
approved these changes
Mar 24, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #1383
Changes:
does not exist in the bundle with which it is initialised in its 'fromBundle' method. Now a null value is passed and hence the crash
does not occur.
The code in SearchFragmentArgs that was throwing the exception is :
if (bundle.containsKey("@string/saved_date")) {// code that inserts it in arguments, redacted for simplicity} else {throw new IllegalArgumentException("Required argument \"@string/saved_date\" is missing anddoes not have an android:defaultValue");}After adding the
android:defaultValue="@null"property to thenavigation.xmlfile, this IllegalArgumentException statement appears to have gone from the generated fileScreenshots for the change: