fix: back button in actionbar #1442
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Details: Previously, when error fetching is displayed, other menu item in actionbar is hided by setting setActionMenu to false. This made the android.R.id.home menu item stop working. So instead of setting the hasActionMenu to false, setting the menu item visibility to false solve problem Fixes: #1436
| val menuItemSize = menuActionBar?.size() ?: 0 | ||
| for (i in 0..(menuItemSize - 1)) { | ||
| menuActionBar?.getItem(i)?.isVisible = !show | ||
| } |
There was a problem hiding this comment.
Sorry but I don't really understand your question? @iamareebjamal
There was a problem hiding this comment.
Does it reappear correctly when we go back?
There was a problem hiding this comment.
As far as I understand, it will reappear correctly because:
- Menu Items visibility will only change on function
showEventErrorScreen() - When error fetching occurs, the error is observed and call that function
showEventErrorScreen()to true -> menu items visibility is false -> disappear - When error fetching stop occurring, the event detail is fetched and the
eventvariable in the ViewModel is observed and call that functionshowEventErrorScreen()to false -> menu items visibility is true -> reappear
You can see it in here from line 84 to 104
eventViewModel.event
.nonNull()
.observe(this, Observer {
loadEvent(it)
eventShare = it
title = eventShare.name
if (eventShare.favorite) {
setFavoriteIcon(R.drawable.ic_baseline_favorite_white)
}
if (runOnce) {
loadSocialLinksFragment()
loadSimilarEventsFragment()
}
runOnce = false
Timber.d("Fetched events of id %d", safeArgs.eventId)
showEventErrorScreen(false)
setHasOptionsMenu(true)
})
iamareebjamal
approved these changes
Mar 27, 2019
nikit19
approved these changes
Mar 28, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details:
Previously, when the error fetching message is displayed, the other menu items in the action bar are hided by setting setHasOptionMenu to false. This made the android.R.id.home menu item stop working.
So instead of setting the setHasOptionMenu to false, setting the menu item visibility to false solve problem
Fixes: #1436
Screenshots for the change:
