chore: reduce app size by removing mapbox #1516
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Details: - Reduce image size - Android Lint to improve some Koitline code, remove unused imports - enable shrinkResource - Set resConfig to "en" as other translation is not fully supported now
|
Proguard is working. Without proguard - 18.8 MB After removing mapbox and jackson-kotlin-module with proguard - 4.7 MB |
| val MAP_LOCATION = "${event.latitude},${event.longitude}" | ||
| val MAP_SETTINGS = "&zoom=15&size=320x200&sensor=false" | ||
| val MAP_KEY = "&key = $GOOGLE_MAP_KEY" | ||
| return MAP_BASE_URL + MAP_LOCATION + MAP_SETTINGS + MAP_KEY |
There was a problem hiding this comment.
This could remain as MapBox is better for free projects
There was a problem hiding this comment.
I have returned it back to Mapbox
| @@ -56,11 +55,37 @@ class SearchLocationFragment : Fragment() { | |||
| redirectToMain() | |||
| }) | |||
|
|
|||
| setupPlaceAutoCompleteFrag(savedInstanceState) | |||
| rootView.locationSearchView.setOnQueryTextListener(object : SearchView.OnQueryTextListener { | |||
There was a problem hiding this comment.
In short, I reverted it back to old SearchLocationFragment where there is only a searchview for user to type in the name of the the place, there isn't location suggestion anymore (I will improve this fragment with retaining old search and hopefully a better autosuggestion solution if this PR is accepted). Here is the view:
| @@ -1,28 +1,18 @@ | |||
| <?xml version="1.0" encoding="utf-8"?> | |||
| <androidx.constraintlayout.widget.ConstraintLayout | |||
| <RelativeLayout | |||
There was a problem hiding this comment.
I have reverted it
Details: Completely remove mapbox and replace current autosuggestion location search view with old search view
app/build.gradle
Outdated
| @@ -22,6 +22,7 @@ android { | |||
| testInstrumentationRunner "androidx.test.runner.AndroidJUnitRunner" | |||
| vectorDrawables.useSupportLibrary = true | |||
| multiDexEnabled true | |||
| resConfigs "en" | |||
iamareebjamal
approved these changes
Apr 3, 2019
iamareebjamal
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1515
Changes:
Currently, the APK size is 7.8MB and the download size is 7.2 MB. One more thing I find is that Proguard is not customized for the project and it still keeps everything so it doesn't help to reduce the app size - if I comment the Proguard line in the app Gradle file, it doesn't change the app size (hope that I understand this correctly). I'll take a closer look at this more on tomorrow