Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Replace setting toolbar with setToolbar #1568

Merged
merged 3 commits into from
Apr 10, 2019
Merged

fix: Replace setting toolbar with setToolbar #1568

merged 3 commits into from
Apr 10, 2019

Conversation

angmas1
Copy link
Contributor

@angmas1 angmas1 commented Apr 8, 2019

Fixes #1490

Changes: Replaced logic with setToolbar.

aggarwalpulkit596
aggarwalpulkit596 reviewed Apr 8, 2019
View reviewed changes
Copy link
Contributor

@aggarwalpulkit596 aggarwalpulkit596 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are some more classes in which this method is not used find and refractor all of them

@aggarwalpulkit596
Copy link
Contributor

aggarwalpulkit596 commented Apr 8, 2019 •
edited
Loading

Also rename the PR title with something like fix: or chore: to pass semantic check

@angmas1
Copy link
Contributor Author

angmas1 commented Apr 8, 2019

Also rename the PR title with something like fix: or chore: to pass semantic check

Oh yeah forgot

@angmas1 angmas1 changed the title Remove setting toolbar with setToolbar fix: Replace setting toolbar with setToolbar Apr 8, 2019
@auto-label auto-label bot added the fix label Apr 8, 2019
@angmas1
Copy link
Contributor Author

angmas1 commented Apr 8, 2019

There are some more classes in which this method is not used find and refractor all of them

I have replaced them all in #1506 , let me know if there are any left.

@angmas1
Copy link
Contributor Author

angmas1 commented Apr 8, 2019

@nikit19 @liveHarshit please review

@iamareebjamal iamareebjamal merged commit 6fda7da into fossasia:development Apr 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aggarwalpulkit596 aggarwalpulkit596 aggarwalpulkit596 left review comments

@liveHarshit liveHarshit liveHarshit approved these changes

@nikit19 nikit19 nikit19 approved these changes

@iamareebjamal iamareebjamal iamareebjamal approved these changes

Assignees
No one assigned
Labels
fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@angmas1 @aggarwalpulkit596 @iamareebjamal @nikit19 @liveHarshit