Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: display shimmer while loading event locations #1586

Merged
merged 1 commit into from
Apr 10, 2019
Merged

feat: display shimmer while loading event locations #1586

merged 1 commit into from
Apr 10, 2019

Conversation

aggarwalpulkit596
Copy link
Contributor

@aggarwalpulkit596 aggarwalpulkit596 commented Apr 10, 2019 •
edited
Loading

Fixes #1585
Changes: Add shimmer while loading event locations

Screenshots for the change:
videotogif_2019 04 10_21 06 30

@auto-label auto-label bot added the feature label Apr 10, 2019
@aggarwalpulkit596
Copy link
Contributor Author

@liveHarshit @iamareebjamal please review

@iamareebjamal iamareebjamal merged commit f81ebce into fossasia:development Apr 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nikit19 nikit19 nikit19 approved these changes

Assignees
No one assigned
Labels
feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aggarwalpulkit596 @nikit19 @iamareebjamal