feat: MapBox AutoComplete Places #1594
Conversation
|
@ShridharGoel @addiegupta @iamareebjamal Please review :) Query |
| private fun loadPlaceSuggestions(query: String) { | ||
| val geoCodingRequest = makeGeocodingRequest(query) | ||
|
|
||
| geoCodingRequest.enqueueCall(object : Callback<GeocodingResponse> { |
There was a problem hiding this comment.
Hello ,I would like to ask , I have called loadPlaceSuggesstion inside compositeDisposable. So why wouln't it cancel the call on dispose ?
app/src/main/java/org/fossasia/openevent/general/search/SearchLocationFragment.kt
Outdated
Show resolved
Hide resolved
| @@ -23,11 +33,44 @@ class SearchLocationViewModel( | |||
| val eventLocations: LiveData<List<EventLocation>> = mutableEventLocations | |||
| private val mutableShowShimmer = MutableLiveData<Boolean>() | |||
| val showShimmer: LiveData<Boolean> = mutableShowShimmer | |||
| private var geoCodingRequest: MapboxGeocoding? = null | |||
There was a problem hiding this comment.
This should be a list of geocoding requests
There was a problem hiding this comment.
What if I cancel the previous request before enqueue new request ? In that way i wont have to maintain list of geocoding requests
- Add MapBox Java lib - Make Popular Locations Hide when Place Suggestions come and Vice-versa - Add debounce to place query newtwork request (to avoid unnecessary calls) - Add english as default language for Suggesstions
UpdateAdd english as language to get the place suggestion in English only (unlike in the GIF of PlayStore VErsion)
|
|
@iamareebjamal I have updated it. Please review it |
|
Peer Review |
|
@ShridharGoel @angmas1 Please review |
Fixes #1529
Changes:
Screenshots for the change:
F-droid
PlayStore
