feat: add hashtags to event cards #1595

aggarwalpulkit596 · 2019-04-12T17:11:18Z

Fixes #1592

Changes: Added Event Types, SubTopics to the database to show hashtags in event cards

Screenshots for the change:

aggarwalpulkit596

@nikit19 any suggestions ?

app/src/main/java/org/fossasia/openevent/general/event/EventService.kt

aggarwalpulkit596 · 2019-04-13T05:46:40Z

I tried using resolve = true but it isn't Saving the object

aggarwalpulkit596 · 2019-04-15T05:35:00Z

@iamareebjamal @nikit19 updated please review

iamareebjamal · 2019-04-15T08:43:16Z

Use the outline style in chip

aggarwalpulkit596 · 2019-04-15T19:59:53Z

@iamareebjamal updated

iamareebjamal · 2019-04-16T04:23:19Z

Peer Review

aggarwalpulkit596 · 2019-04-16T04:41:35Z

@liveHarshit please review

liveHarshit · 2019-04-16T17:37:14Z

UI is not looking good. You can decrease the size to make UI effective.

aggarwalpulkit596 · 2019-04-16T17:42:52Z

okay anything related to code @liveHarshit ?

liveHarshit

Please revert unnecessary changes

liveHarshit · 2019-04-16T17:44:10Z

app/src/main/java/org/fossasia/openevent/general/event/EventDetailsFragment.kt

@@ -27,6 +27,7 @@ import kotlinx.android.synthetic.main.content_event.similarEventsContainer
 import kotlinx.android.synthetic.main.content_event.view.eventDateDetailsFirst
 import kotlinx.android.synthetic.main.content_event.view.eventDateDetailsSecond
 import kotlinx.android.synthetic.main.content_event.view.eventDescription
+import kotlinx.android.synthetic.main.content_event.view.eventImage


Unrelated changes

liveHarshit · 2019-04-16T17:44:18Z

app/src/main/java/org/fossasia/openevent/general/event/EventDetailsFragment.kt

 import kotlinx.android.synthetic.main.content_event.view.nestedContentEventScroll
+import kotlinx.android.synthetic.main.content_event.view.organizerContainer
+import kotlinx.android.synthetic.main.content_event.view.organizerLogoIcon


liveHarshit · 2019-04-16T17:44:48Z

app/src/main/java/org/fossasia/openevent/general/event/EventDetailsFragment.kt

 import kotlinx.android.synthetic.main.fragment_event.view.container
-import kotlinx.android.synthetic.main.content_fetching_event_error.view.retry


app/src/main/java/org/fossasia/openevent/general/event/EventDetailsFragment.kt

aggarwalpulkit596 · 2019-04-16T18:05:11Z

UI is not looking good. You can decrease the size to make UI effective.

@liveHarshit which one you're referring to outline or purple colored ones?

liveHarshit · 2019-04-16T18:06:29Z

UI is not looking good. You can decrease the size to make UI effective.

@liveHarshit which one you're referring to outline or purple colored ones?

The overall size of the chips.

aggarwalpulkit596 · 2019-04-16T19:19:18Z

@liveHarshit updated

iamareebjamal · 2019-04-17T16:17:31Z

The error is unrelated to GSON, and we are not even using GSON

app/src/main/java/org/fossasia/openevent/general/event/subtopic/EventSubTopicIdConverter.kt

iamareebjamal · 2019-04-17T16:22:13Z

If we are using it, then please remove it as we already have Jackson

aggarwalpulkit596 · 2019-04-17T16:28:07Z

@iamareebjamal here gson is used to
A Java serialization/deserialization library to convert Java Objects into JSON and back

aggarwalpulkit596 · 2019-04-17T16:39:12Z

@iamareebjamal i'm extremely sorry it was my mistake i forgot to push the build.gradle file in which i added a library

aggarwalpulkit596 · 2019-04-17T16:41:48Z

@iamareebjamal @liveHarshit updated it should work now

iamareebjamal · 2019-04-17T16:47:38Z

app/build.gradle

@@ -118,6 +118,7 @@ dependencies {
    testImplementation "androidx.room:room-testing:${roomVersion}"
    implementation 'androidx.preference:preference:1.1.0-alpha01'
    implementation "org.jetbrains.kotlin:kotlin-stdlib-jdk7:$kotlin_version"
+    implementation "com.google.code.gson:gson:2.8.5"


type converter can't work without them

What is GSON?

And why do you need it when the project is using Jackson

GSON
A Java serialization/deserialization library to convert Java Objects into JSON and back
Refrences
https://medium.com/@amit.bhandari/storing-java-objects-other-than-primitive-types-in-room-database-11e45f4f6d22

class EventTypeConverter {

@TypeConverter fun toEventSubTopic(json: String): EventType? { val type = object : TypeToken<EventType>() {}.type return Gson().fromJson(json, type) } @TypeConverter fun toJson(eventSubTopic: EventType?) = Gson().toJson(eventSubTopic) }

here the implementation can't be achieved using jackson

Why can't it be done using Jackson?

i couldn't find any methods for such thing
https://stackoverflow.com/questions/49064618/typetoken-getparameterized-in-jackson-json

I don't think I have a job of pointing to the documentation of a JSON serializing library

http://lmgtfy.com/?q=convert+object+jackson

@iamareebjamal i'm sorry and intiallly thought you weren't getting the point of gson/jackson for the converter

aggarwalpulkit596 · 2019-04-17T17:00:07Z

app/build.gradle

@@ -118,6 +118,7 @@ dependencies {
    testImplementation "androidx.room:room-testing:${roomVersion}"
    implementation 'androidx.preference:preference:1.1.0-alpha01'
    implementation "org.jetbrains.kotlin:kotlin-stdlib-jdk7:$kotlin_version"
+    implementation "com.google.code.gson:gson:2.8.5"


i need it to convert event topic,subtopic and type model into event model by converting into gson and then converting it back to respective models

app/src/main/java/org/fossasia/openevent/general/event/subtopic/EventSubTopicConverter.kt

aggarwalpulkit596 · 2019-04-17T19:24:55Z

@iamareebjamal updated.Thank you

iamareebjamal · 2019-04-17T19:45:25Z

app/src/main/java/org/fossasia/openevent/general/OpenEventDatabase.kt

@@ -42,5 +50,9 @@ abstract class OpenEventDatabase : RoomDatabase() {

    abstract fun eventTopicsDao(): EventTopicsDao

+    abstract fun eventTypesDao(): EventTypesDao
+
+    abstract fun eventSubTopicDao(): EventSubTopicDao


Since these are now stored with the event, this is unneeded

but we can use these dao in future for chips or filtering i suggest we should keep them

We can't use them unless there is a table for them

i'm saving them as well in a seperate table i could remove that part though but we may need them in future

aggarwalpulkit596 · 2019-04-17T19:50:09Z

app/src/main/java/org/fossasia/openevent/general/event/EventService.kt

@@ -76,6 +94,8 @@ class EventService(
        return eventApi.searchEvents("name", locationName).flatMap { apiList ->
            val eventIds = apiList.map { it.id }.toList()
            eventTopicsDao.insertEventTopics(getEventTopicList(apiList))
+            eventTypesDao.insertEventTypes(getEventTypeList(apiList))


@iamareebjamal i'm saving them individually as well so there is a table for them as well

Why are you converting in JSON then? Just save them as JSON. No need to add tables

okay i'll remove them

iamareebjamal · 2019-04-17T21:06:05Z

Since new columns have been added to the table, there must be changes in schema JSON

aggarwalpulkit596 · 2019-04-18T19:15:00Z

@iamareebjamal updated JSON schema

aggarwalpulkit596 · 2019-04-19T02:44:36Z

Resolved Conflicts

iamareebjamal · 2019-04-19T03:59:33Z

app/src/main/java/org/fossasia/openevent/general/event/subtopic/EventSubTopicConverter.kt

+class EventSubTopicConverter {
+    @TypeConverter
+    fun toEventSubTopic(json: String): EventSubTopic? {
+        return jacksonObjectMapper().readerFor(EventSubTopic::class.java).readValue<EventSubTopic>(json)


There's already an object mapper in dependency graph, use that

aggarwalpulkit596 · 2019-04-19T04:13:44Z

app/src/main/java/org/fossasia/openevent/general/event/subtopic/EventSubTopicConverter.kt

+class EventSubTopicConverter {
+    @TypeConverter
+    fun toEventSubTopic(json: String): EventSubTopic? {
+        val objectMapper = ObjectMapper()


@iamareebjamal updated

No, this is still instantiating ObjectMapper yourself

@iamareebjamal
val mapType = object : TypeReference() {}
return ObjectMapper().readValue(json, mapType)
like this ?
instead of
val objectMapper = ObjectMapper()
val mapType = object : TypeReference() {}
return ObjectMapper().readValue(json, mapType)

No, you need to use the ObjectMapper from DI. Who said anything about TypeReference or that your implementation was wrong

@iamareebjamal how i can pass that in type converter because type converter can only have empty constructors

and also ListAttendeeIdConverter uses the same pattern because we can't pass anything to type converter

@iamareebjamal anything else?

You can manually inject the dependency. See field injection

but for field injection, we need a context or something type converter don't even have that
i tired using StandAloneContext.getKoin().koinContext and val objectMapper: ObjectMapper by inject()

OK. Create an issue to convert all object mappers from the one in DI

aggarwalpulkit596 · 2019-04-20T15:35:42Z

@iamareebjamal please review

iamareebjamal · 2019-04-20T16:49:49Z

app/src/main/java/org/fossasia/openevent/general/event/types/EventTypeConverter.kt

+    @TypeConverter
+    fun toEventType(json: String): EventType? {
+        val mapType = object : TypeReference<EventType>() {}
+        return ObjectMapper().readValue(json, mapType) }


Revert to how it was before

aggarwalpulkit596 · 2019-04-20T16:53:52Z

@iamareebjamal updated

nikit19 · 2019-04-20T18:45:01Z

app/src/main/java/org/fossasia/openevent/general/event/EventViewHolder.kt

+                addchips(it.name)
+        }
+        event.eventSubTopic.let {
+            if (it != null)


any particular reason for explicit null checks?
Using ?.let would work?

aggarwalpulkit596 commented Apr 12, 2019

View reviewed changes

app/src/main/java/org/fossasia/openevent/general/event/EventService.kt Outdated Show resolved Hide resolved

aggarwalpulkit596 force-pushed the 1592 branch 3 times, most recently from a9914f2 to 3999c03 Compare April 15, 2019 05:33

aggarwalpulkit596 changed the title ~~[WIP]feat: add hashtags to event cards~~ feat: add hashtags to event cards Apr 15, 2019

auto-label bot added the feature label Apr 15, 2019

aggarwalpulkit596 force-pushed the 1592 branch 2 times, most recently from 90a2afb to bdaa97f Compare April 15, 2019 19:57

aggarwalpulkit596 force-pushed the 1592 branch from bdaa97f to f141359 Compare April 15, 2019 21:06

liveHarshit reviewed Apr 16, 2019

View reviewed changes

aggarwalpulkit596 force-pushed the 1592 branch 2 times, most recently from 8b51d36 to 4d84231 Compare April 16, 2019 19:44

aggarwalpulkit596 commented Apr 17, 2019

View reviewed changes

app/src/main/java/org/fossasia/openevent/general/event/subtopic/EventSubTopicIdConverter.kt Outdated Show resolved Hide resolved

aggarwalpulkit596 force-pushed the 1592 branch from 4d84231 to 97c037b Compare April 17, 2019 16:41

iamareebjamal reviewed Apr 17, 2019

View reviewed changes

aggarwalpulkit596 commented Apr 17, 2019

View reviewed changes

aggarwalpulkit596 force-pushed the 1592 branch from 97c037b to 23c4085 Compare April 17, 2019 19:24

iamareebjamal reviewed Apr 17, 2019

View reviewed changes

aggarwalpulkit596 commented Apr 17, 2019

View reviewed changes

aggarwalpulkit596 force-pushed the 1592 branch from 23c4085 to fecca8d Compare April 17, 2019 20:02

aggarwalpulkit596 force-pushed the 1592 branch 2 times, most recently from 474e435 to 6acc55c Compare April 18, 2019 19:13

aggarwalpulkit596 force-pushed the 1592 branch from 6acc55c to c8b6ccc Compare April 19, 2019 02:43

iamareebjamal reviewed Apr 19, 2019

View reviewed changes

aggarwalpulkit596 force-pushed the 1592 branch from c8b6ccc to 3e086dd Compare April 19, 2019 04:13

aggarwalpulkit596 commented Apr 19, 2019

View reviewed changes

aggarwalpulkit596 force-pushed the 1592 branch from 3e086dd to acdfe52 Compare April 19, 2019 09:27

iamareebjamal reviewed Apr 20, 2019

View reviewed changes

feat: add hashtags to event cards

a422cb8

aggarwalpulkit596 force-pushed the 1592 branch from acdfe52 to a422cb8 Compare April 20, 2019 16:53

iamareebjamal approved these changes Apr 20, 2019

View reviewed changes

Merge branch 'development' into 1592

9e6ac4a

nikit19 approved these changes Apr 20, 2019

View reviewed changes

iamareebjamal merged commit 0a2f916 into fossasia:development Apr 20, 2019

nikit19 reviewed Apr 20, 2019

View reviewed changes

		import kotlinx.android.synthetic.main.fragment_event.view.container
		import kotlinx.android.synthetic.main.content_fetching_event_error.view.retry

feat: add hashtags to event cards #1595

feat: add hashtags to event cards #1595

Conversation

aggarwalpulkit596 commented Apr 12, 2019 • edited Loading

aggarwalpulkit596 left a comment

Choose a reason for hiding this comment

aggarwalpulkit596 commented Apr 13, 2019

aggarwalpulkit596 commented Apr 15, 2019

iamareebjamal commented Apr 15, 2019

aggarwalpulkit596 commented Apr 15, 2019

iamareebjamal commented Apr 16, 2019

aggarwalpulkit596 commented Apr 16, 2019

liveHarshit commented Apr 16, 2019

aggarwalpulkit596 commented Apr 16, 2019

liveHarshit left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

aggarwalpulkit596 commented Apr 16, 2019

liveHarshit commented Apr 16, 2019

aggarwalpulkit596 commented Apr 16, 2019

iamareebjamal commented Apr 17, 2019

iamareebjamal commented Apr 17, 2019 • edited Loading

aggarwalpulkit596 commented Apr 17, 2019

aggarwalpulkit596 commented Apr 17, 2019

aggarwalpulkit596 commented Apr 17, 2019

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

aggarwalpulkit596 Apr 17, 2019 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

aggarwalpulkit596 commented Apr 17, 2019

Choose a reason for hiding this comment

aggarwalpulkit596 Apr 17, 2019 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

aggarwalpulkit596 Apr 17, 2019 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

iamareebjamal commented Apr 17, 2019

aggarwalpulkit596 commented Apr 18, 2019

aggarwalpulkit596 commented Apr 19, 2019

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

aggarwalpulkit596 commented Apr 20, 2019

Choose a reason for hiding this comment

aggarwalpulkit596 commented Apr 20, 2019

Choose a reason for hiding this comment

aggarwalpulkit596 commented Apr 12, 2019 •

edited

Loading

iamareebjamal commented Apr 17, 2019 •

edited

Loading

aggarwalpulkit596 Apr 17, 2019 •

edited

Loading

aggarwalpulkit596 Apr 17, 2019 •

edited

Loading

aggarwalpulkit596 Apr 17, 2019 •

edited

Loading