-
Notifications
You must be signed in to change notification settings - Fork 551
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add event feedback #1601
feat: add event feedback #1601
Conversation
2e7c888
to
5266df7
Compare
@liveHarshit @iamareebjamal review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Screenshot pls
@nikit19 couldn't add a screenshot as there was no Event with a feedback and i was unable to create a feedback manually using the api.I already have created an issue on server for the same |
5266df7
to
231c74d
Compare
@nikit19 updated |
231c74d
to
dd359c3
Compare
@liveHarshit please review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reset lgtm
app/src/main/java/org/fossasia/openevent/general/event/EventDetailsViewModel.kt
Outdated
Show resolved
Hide resolved
3fb5a39
to
5282214
Compare
@liveHarshit @iamareebjamal updated |
@iamareebjamal anything left out? |
PRF |
eventViewModel.eventFeedback.observe(viewLifecycleOwner, Observer { | ||
feedbackAdapter.addAll(it) | ||
if (it.isEmpty()) { | ||
rootView.feedbackContainer.visibility = View.GONE |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Replace with rootView.feedbackContainer.isVisible = false
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Replace with
rootView.feedbackContainer.isVisible = false
What is the advantage?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Much clearer and using booleans (primitives)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@liveHarshit any other change ?
@liveHarshit updated |
5282214
to
d3b2c3a
Compare
val id: Long, | ||
val rating: String?, | ||
val comment: String?, | ||
@JsonProperty("deleted-at") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unneeded
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@iamareebjamal updated
d3b2c3a
to
b521038
Compare
Fixes #1591 part 1
Changes: added event feedback section for a particular event
Screenshots for the change: