feat: Notification Fragment

[iamanbansal]

Part of #1617

Changes: fragment setup

[nikit19]

When you submit a WIP PR, it helps if you could point out where you are having problems

[iamanbansal]

@iamareebjamal @nikit19 Need your suggestion on following points

• where should we show notification button

• what to implement
  if(userLoggedin) show notification button
  else no button
  or
  onButtonClick navigate user to login if not logged in

• how to delete notifications? My suggestion is swipe to delete

• when to mark notification as read?

• how to open the link from notification message
  Your order has been processed successfully.<br><br><a href='https://eventyay.com/orders/c7883741-3fcd-4801-828d-eaae999f97e7/view/' class='btn btn-info btn-sm'>View Invoice</a>

Current Status

[iamareebjamal]

Don't delete notifications, just mark read. Show notification button always, in case not logged in we'll show local notifications (planned later)

If there are no local notifications, we'll show Sign Up to see notifications

There'll be a button to mark all notifications as read since there is no notification target as of now

We'll use Html.fromHtml for now. The backend structure for notification will change

notification {
  actor {
    user {
      id: 345
      name: Areeb Jamal
    }
  }
  target {
    order {
      id: 'OH-232353'
      link: 'https://whatevs.com'
    }
  }
  type: order-complete
}

[iamanbansal]

todo:
mark notification as read or unread

@iamareebjamal @nikit19 please review

[iamanbansal]

@iamareebjamal @liveHarshit @nikit19 please review

[iamareebjamal]

PRF

[iamanbansal]

PRF

Sorry, what?

[aggarwalpulkit596]

Peer review first 😅

[liveHarshit]

Why are you checking again for authentication?

[iamanbansal]

To prevent the api call if not logged in.
then in onStart, redirect to login.

[liveHarshit]

But onCreateView is always called after onStart, so can't you remove onStart here?

[iamanbansal]

bro no, onStart is called after onActivityCreated
https://developer.android.com/guide/components/fragments

[aggarwalpulkit596]

@aman210697 if you're still working on this please resolve conflicts and if not I'll do it

[iamanbansal]

@aman210697 if you're still working on this please resolve conflicts and if not I'll do it

Conflicts are not big, so I'll update it before the approval.
And why do you want to do it again? Just review my PR.

[aggarwalpulkit596]

@aman210697 if you're still working on this please resolve conflicts and if not I'll do it

Conflicts are not big, so I'll update it before the approval.
And why do you want to do it again? Just review my PR.

I was talking about resolving the conflicts

[iamanbansal]

@aman210697 if you're still working on this please resolve conflicts and if not I'll do it

Conflicts are not big, so I'll update it before the approval.
And why do you want to do it again? Just review my PR.

I was talking about resolving the conflicts

Resolved conflicts, and updated to RxKotlin & RxExtensions.. Please review

[anhanh11001]

may I fork this PR and finish it by resolving conflicts?

[iamanbansal]

may I fork this PR and finish it by resolving conflicts?

If you haven't started yet, I'll resolve..

[anhanh11001]

@aman210697 oh great

[iamanbansal]

resolve conflicts and updated navigation ACTIONS API