-
Notifications
You must be signed in to change notification settings - Fork 551
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add shared element transition #1688
feat: Add shared element transition #1688
Conversation
@anhanh11001 please refer this you willl find solution for return transition #1443 |
@anhanh11001 if you're not working on this should I check #1443 for the bug that caused for it to be reverted |
Actually, I have finished them (I think so), I haven't uploaded the latest version because it slows down the app and at first I thought it was some problem in this PR but then I figured it out it was #1705. So I want to finish 1705 first before actually testing the performance of this PR. So maybe if you can also take a look at #1705 and also send a PR about it, that would be nice |
@anhanh11001 sure will take a look and can you take a look at #1477 to make sure these bugs are not happening again |
@aggarwalpulkit596 Yes I will, if I still have problems I will tell you |
Detail: - Add shared element transition for event card list to details Fixes: #1686
updated |
@anhanh11001 Have you tested it for search results? Search is not working and the app is crashing on going back. |
@liveHarshit it is same error which was in my implementation |
There is some issue with the navigation architecture i guess |
Likes and events are working fine. Here the issue is with search fragment |
check #1477 |
You can compare if the method of implementation is same. |
@liveHarshit can you tell me how to reproduce it, because I have tested and it is working fine in my device |
On my device search is not redirecting to search fragment, only title changes and after coming back app crashes. |
Let me share logs |
|
@liveHarshit I think I know the problem now, it is not the same as #1477, fixing now |
Fixes: #1686
Screenshots for the change:
![ezgif-2-c012b715d128](https://camo.githubusercontent.com/2ab21561d48605c7ccf9aab2157a740e932bbfb2158c230acd2925ea8425c3a1/68747470733a2f2f692e6962622e636f2f4b30536d4a386e2f657a6769662d322d6330313262373135643132382e676966)