Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add shared element transition #1688

Merged
merged 1 commit into from
May 19, 2019
Merged

feat: Add shared element transition #1688

merged 1 commit into from
May 19, 2019

Conversation

anhanh11001
Copy link
Contributor

@anhanh11001 anhanh11001 commented Apr 28, 2019

Fixes: #1686

  • Add shared element transition between event detail and event list.
  • Remove unused Scope file.

Screenshots for the change:
ezgif-2-5e8abfb58111 ezgif-2-069709e4221f ezgif-2-c012b715d128

@aggarwalpulkit596
Copy link
Contributor

@anhanh11001 please refer this you willl find solution for return transition #1443

@anhanh11001 anhanh11001 changed the title [WIP] feat: Add shared element transition feat: Add shared element transition Apr 29, 2019
@auto-label auto-label bot added the feature label Apr 29, 2019
@anhanh11001 anhanh11001 changed the title feat: Add shared element transition WIP - feat: Add shared element transition Apr 29, 2019
@auto-label auto-label bot removed the feature label Apr 29, 2019
@aggarwalpulkit596
Copy link
Contributor

@anhanh11001 if you're not working on this should I check #1443 for the bug that caused for it to be reverted

@anhanh11001
Copy link
Contributor Author

Actually, I have finished them (I think so), I haven't uploaded the latest version because it slows down the app and at first I thought it was some problem in this PR but then I figured it out it was #1705. So I want to finish 1705 first before actually testing the performance of this PR. So maybe if you can also take a look at #1705 and also send a PR about it, that would be nice

@aggarwalpulkit596
Copy link
Contributor

@anhanh11001 sure will take a look and can you take a look at #1477 to make sure these bugs are not happening again

@anhanh11001
Copy link
Contributor Author

@aggarwalpulkit596 Yes I will, if I still have problems I will tell you

@anhanh11001 anhanh11001 changed the title WIP - feat: Add shared element transition feat: Add shared element transition May 17, 2019
@auto-label auto-label bot added the feature label May 17, 2019
Detail:
- Add shared element transition for event card list to details

Fixes: #1686
@fossasia fossasia deleted a comment May 19, 2019
@fossasia fossasia deleted a comment May 19, 2019
@fossasia fossasia deleted a comment May 19, 2019
@fossasia fossasia deleted a comment from liveHarshit May 19, 2019
@fossasia fossasia deleted a comment May 19, 2019
@fossasia fossasia deleted a comment May 19, 2019
@anhanh11001
Copy link
Contributor Author

updated

@iamareebjamal iamareebjamal merged commit b159a07 into fossasia:development May 19, 2019
@liveHarshit
Copy link
Member

@anhanh11001 Have you tested it for search results? Search is not working and the app is crashing on going back.

@aggarwalpulkit596
Copy link
Contributor

@liveHarshit it is same error which was in my implementation

@aggarwalpulkit596
Copy link
Contributor

There is some issue with the navigation architecture i guess

@liveHarshit
Copy link
Member

liveHarshit commented May 20, 2019

@liveHarshit it is same error which was in my implementation

Likes and events are working fine. Here the issue is with search fragment

@aggarwalpulkit596
Copy link
Contributor

check #1477

@liveHarshit
Copy link
Member

You can compare if the method of implementation is same.

@anhanh11001
Copy link
Contributor Author

@liveHarshit can you tell me how to reproduce it, because I have tested and it is working fine in my device

@liveHarshit
Copy link
Member

On my device search is not redirecting to search fragment, only title changes and after coming back app crashes.

@liveHarshit
Copy link
Member

Let me share logs

@liveHarshit
Copy link
Member

E/EventViewHolder$bind$$inlined$let$lambda: com.squareup.picasso.NetworkRequestHandler$ResponseException: HTTP 404
        at com.squareup.picasso.NetworkRequestHandler.load(NetworkRequestHandler.java:51)
        at com.squareup.picasso.BitmapHunter.hunt(BitmapHunter.java:219)
        at com.squareup.picasso.BitmapHunter.run(BitmapHunter.java:175)
        at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:428)
        at java.util.concurrent.FutureTask.run(FutureTask.java:237)
        at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1133)
        at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:607)
        at java.lang.Thread.run(Thread.java:760)
        at com.squareup.picasso.Utils$PicassoThread.run(Utils.java:354)
E/AndroidRuntime: FATAL EXCEPTION: main
    Process: com.eventyay.attendee, PID: 10831
    java.lang.NullPointerException: Attempt to invoke virtual method 'boolean androidx.fragment.app.FragmentManagerImpl.isPrimaryNavigation(androidx.fragment.app.Fragment)' on a null object reference
        at androidx.fragment.app.Fragment.performPrimaryNavigationFragmentChanged(Fragment.java:2710)
        at androidx.fragment.app.FragmentManagerImpl.dispatchParentPrimaryNavigationFragmentChanged(FragmentManagerImpl.java:2795)
        at androidx.fragment.app.FragmentManagerImpl.setPrimaryNavigationFragment(FragmentManagerImpl.java:2790)
        at androidx.fragment.app.BackStackRecord.executeOps(BackStackRecord.java:422)
        at androidx.fragment.app.FragmentManagerImpl.completeExecute(FragmentManagerImpl.java:1979)
        at androidx.fragment.app.FragmentManagerImpl$StartEnterTransitionListener.completeTransaction(FragmentManagerImpl.java:3371)
        at androidx.fragment.app.FragmentManagerImpl.executePostponedTransaction(FragmentManagerImpl.java:1759)
        at androidx.fragment.app.FragmentManagerImpl.removeRedundantOperationsAndExecute(FragmentManagerImpl.java:1790)
        at androidx.fragment.app.FragmentManagerImpl.execPendingActions(FragmentManagerImpl.java:1717)
        at androidx.fragment.app.FragmentManagerImpl$2.run(FragmentManagerImpl.java:150)
        at android.os.Handler.handleCallback(Handler.java:754)
        at android.os.Handler.dispatchMessage(Handler.java:95)

@anhanh11001
Copy link
Contributor Author

@liveHarshit I think I know the problem now, it is not the same as #1477, fixing now

@anhanh11001 anhanh11001 deleted the 1686_shared_element_transition branch June 20, 2019 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Share element transition
4 participants