feat: Update settings and profile fragment for non authenticated users #1754
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anhanh11001
reviewed
May 12, 2019
| if (profileViewModel.isLoggedIn()) { | ||
| handleLayoutVisibility(true) | ||
| } else { | ||
| handleLayoutVisibility(false) |
There was a problem hiding this comment.
if (profileViewModel.isLoggedIn()) {
handleLayoutVisibility(true)
} else {
handleLayoutVisibility(false)
This can be written as a single line like handleLayoutVisibility(profileViewModel.isLoggedIn()). I think it is cleaner
There was a problem hiding this comment.
Oh, thanks for pointing. 👍
anhanh11001
previously approved these changes
May 12, 2019
nikit19
reviewed
May 13, 2019
There was a problem hiding this comment.
Please make the changes suggested by @anhanh11001 . Rest looks good
|
Updated |
iamareebjamal
approved these changes
May 13, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1750
For not logged in -
For logged in -