Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Improve AttendeeFragment #1890

Merged
merged 1 commit into from
Jun 3, 2019
Merged

fix: Improve AttendeeFragment #1890

merged 1 commit into from
Jun 3, 2019

Conversation

anhanh11001
Copy link
Contributor

Details:

  • Set up more logically time display of event
  • Remove card type selector as it doesn't matter that much. Stripe automatically determine card type based on card number provided
  • Hide billing information for free tickets
  • Show pop up message for "required fields should be filled"
  • Remove confirm dialog on ordering ticket (based on Eventbrite)

Fixes #1885

Details:
- Set up more logically time display of event
- Remove card type selector as it doesn't matter that much. Stripe automatically determine card type based on card number provided
- Hide billing information for free tickets
- Show pop up message for "required fields should be filled"
- Remove confirm dialog on ordering ticket (based on Eventbrite)
@auto-label auto-label bot added the fix label Jun 3, 2019
@anhanh11001 anhanh11001 requested a review from liveHarshit June 3, 2019 12:48
@iamareebjamal iamareebjamal merged commit e8c8dbb into fossasia:development Jun 3, 2019
@anhanh11001 anhanh11001 deleted the 1885_attendee_fragment_problems branch June 20, 2019 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Multiple small problems in AttendeeFragment
3 participants