fix: crash on sign up

[anhanh11001]

Details:

• Move hint from TextInputEditText to TextInputLayout due to an Android bug that create a crash
• Add check so that when clicking on Google Auth in LoginFragment, it doesn't redirect back to AuthFragment

Related issue:
https://stackoverflow.com/questions/45898228/android-attempt-to-invoke-virtual-method-void-android-view-view-getboundsonsc

Fixes: #1923
Fixes #1920

Need to solve #1920 with it. As both are due to text watcher.

[liveHarshit]

 if (BuildConfig.FLAVOR == PLAY_STORE_BUILD_FLAVOR) {

            smartAuthViewModel.requestCredentials(SmartAuthUtil.getCredentialsClient(requireActivity()))

            smartAuthViewModel.id
                .nonNull()
                .observe(viewLifecycleOwner, Observer {
                    email.text = SpannableStringBuilder(it)
                })

            smartAuthViewModel.password
                .nonNull()
                .observe(viewLifecycleOwner, Observer {
                    password.text = SpannableStringBuilder(it)
                })

            smartAuthViewModel.apiExceptionCodePair.nonNull().observe(viewLifecycleOwner, Observer {
                SmartAuthUtil.handleResolvableApiException(
                    it.first, requireActivity(), it.second)
            })

            smartAuthViewModel.progress
                .nonNull()
                .observe(viewLifecycleOwner, Observer {
                    progressDialog.show(it)
                })
        }

Here it fails.

[anhanh11001]

I think a workaround is to move this block of code

 rootView.email.addTextChangedListener(object : TextWatcher {
            override fun afterTextChanged(s: Editable) {
 if (s.toString() != safeArgs.email)
                    findNavController(rootView).navigate(LoginFragmentDirections
                        .actionLoginToAuthPop(redirectedFrom = safeArgs.redirectedFrom, email = s.toString()))
   override fun beforeTextChanged(s: CharSequence, start: Int, count: Int, after: Int) { /*Do Nothing*/ }
            override fun onTextChanged(email: CharSequence, start: Int, before: Int, count: Int) { /*Do Nothing*/ }
        })

into here

if (safeArgs.email.isNotEmpty()) {
            rootView.email.text = SpannableStringBuilder(safeArgs.email)
        // HERE <------------------------
} else if (BuildConfig.FLAVOR == PLAY_STORE_BUILD_FLAVOR) {

            smartAuthViewModel.requestCredentials(SmartAuthUtil.getCredentialsClient(requireActivity()))

            smartAuthViewModel.id
                .nonNull()
                .observe(viewLifecycleOwner, Observer {
                    email.text = SpannableStringBuilder(it)
                    Timber.d("DEBUGGING ${email.text.toString()}")
                })

            smartAuthViewModel.password
                .nonNull()
                .observe(viewLifecycleOwner, Observer {
                    password.text = SpannableStringBuilder(it)
                })

            smartAuthViewModel.apiExceptionCodePair.nonNull().observe(viewLifecycleOwner, Observer {
                SmartAuthUtil.handleResolvableApiException(
                    it.first, requireActivity(), it.second)
            })

            smartAuthViewModel.progress
                .nonNull()
                .observe(viewLifecycleOwner, Observer {
                    progressDialog.show(it)
                })
        }

[liveHarshit]

Good idea. Do the changes and will test if both bugs will fix.

[anhanh11001]

I have pushed a new update, can you test it as I'm still struggling to set up the environment. Somehow, my device can't save credential with ApiException from Google API for saving credential

[liveHarshit]

Sure

[liveHarshit]

Both solved. One little bug is there with smart auth, will solve that later. 👍

[iamareebjamal]

Writing Fixes and multiple issues on same line does not work

[iamareebjamal]

@anhanh11001 Your commit closed #1922