Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Progress dialog is continued showing on error in attendee fragment #1959

Merged
merged 2 commits into from
Jun 15, 2019
Merged

fix: Progress dialog is continued showing on error in attendee fragment #1959

merged 2 commits into from
Jun 15, 2019

Conversation

liveHarshit
Copy link
Member

Fixes #1946

@liveHarshit liveHarshit requested a review from anhanh11001 June 14, 2019 18:07
@auto-label auto-label bot added the fix label Jun 14, 2019
nikit19
nikit19 previously approved these changes Jun 14, 2019
View reviewed changes
@ShridharGoel
Copy link
Member

@liveHarshit Isn't the mutableProgress.value required to be set to false in this case too?

if (it.message.equals(HttpErrors.CONFLICT)) {
    mutableTicketSoldOut.value = true
}

anhanh11001
anhanh11001 previously approved these changes Jun 14, 2019
View reviewed changes
@liveHarshit liveHarshit dismissed stale reviews from anhanh11001 and nikit19 via 1210b97 June 15, 2019 03:27
@liveHarshit
Copy link
Member Author

@liveHarshit Isn't the mutableProgress.value required to be set to false in this case too?

if (it.message.equals(HttpErrors.CONFLICT)) {
    mutableTicketSoldOut.value = true
}

Yes it should. Sorry, I did it by mistake.

@liveHarshit liveHarshit requested a review from ShridharGoel June 15, 2019 03:28
@iamareebjamal iamareebjamal merged commit cccc1de into fossasia:development Jun 15, 2019
@liveHarshit liveHarshit mentioned this pull request Jun 15, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iamareebjamal iamareebjamal iamareebjamal approved these changes

@ShridharGoel ShridharGoel ShridharGoel approved these changes

@nikit19 nikit19 nikit19 left review comments

@anhanh11001 anhanh11001 anhanh11001 left review comments

Assignees
No one assigned
Labels
fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Progress bar is continued showing on throwing error
5 participants
@liveHarshit @ShridharGoel @iamareebjamal @nikit19 @anhanh11001