feat: Handle app link intent for password reset and add unit test #2081
Conversation
app/src/main/java/org/fossasia/openevent/general/MainActivity.kt
Outdated
Show resolved
Hide resolved
| @@ -212,7 +212,7 @@ val apiModule = module { | |||
|
|
|||
| val viewModelModule = module { | |||
| viewModel { LoginViewModel(get(), get(), get()) } | |||
| viewModel { EventsViewModel(get(), get(), get(), get(), get(), get(), get()) } | |||
| viewModel { EventsViewModel(get(), get(), get(), get(), get(), get(), get(), get()) } | |||
There was a problem hiding this comment.
This is getting too big. Open issue to refactor and break into smaller ViewModels
For e.g, similar event functionality should be in its own ViewModel
There was a problem hiding this comment.
Where is the issue?
There was a problem hiding this comment.
similar event functionality should be in its own ViewModel
It's not there, and there are only 4-5 methods, the view model is not so long. We can separate authentication related functions only.
There was a problem hiding this comment.
So why 8 parameters are required in it?
There was a problem hiding this comment.
private val eventService: EventService,
private val preference: Preference,
private val resource: Resource,
private val mutableConnectionLiveData: MutableConnectionLiveData,
private val authHolder: AuthHolder,
private val authService: AuthService,
private val notificationService: NotificationService,
private val config: PagedList.ConfigThere was a problem hiding this comment.
Can this be merged, issue #2083 is opened for it, will work on that.
| else -> { | ||
| bundle.putString(EVENT_IDENTIFIER, appLinkData.lastPathSegment) | ||
| navController.navigate(R.id.eventDetailsFragment, bundle) | ||
| } |
There was a problem hiding this comment.
Add a separate class to parse and navigate and add tests
app/src/main/java/org/fossasia/openevent/general/MainActivity.kt
Outdated
Show resolved
Hide resolved
|
@iamareebjamal Updated |
liveHarshit
changed the title
app/src/test/java/org/fossasia/openevent/general/AppLinkUtilsTest.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/org/fossasia/openevent/general/utils/AppLinkUtils.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/org/fossasia/openevent/general/utils/AppLinkData.kt
Outdated
Show resolved
Hide resolved
app/src/test/java/org/fossasia/openevent/general/AppLinkUtilsTest.kt
Outdated
Show resolved
Hide resolved
app/src/test/java/org/fossasia/openevent/general/AppLinkUtilsTest.kt
Outdated
Show resolved
Hide resolved
app/src/test/java/org/fossasia/openevent/general/AppLinkUtilsTest.kt
Outdated
Show resolved
Hide resolved
|
Updated |
|
|
||
| class AppLinkUtilsTest { | ||
|
|
||
| private fun getAppLink(type: String): String { |
There was a problem hiding this comment.
Can we remove the function and directly write URLs, as I don't think there is any repetition
| object AppLinkUtils { | ||
| fun getData(uri: String): AppLinkData? { | ||
| val value = uri.split("/", "?", "=").last() | ||
| return when (uri.split("/", "?", "=")[3]) { |
There was a problem hiding this comment.
Why split 2 times, just do once
Fixes #2079