feat: Add chaining RxJava #2117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nikit19
previously approved these changes
Jul 14, 2019
iamareebjamal
requested changes
Jul 14, 2019
| else | ||
| authService.uploadImage(UploadImage(encodedImage)).flatMap { | ||
| authService.updateUser(User(id = id, firstName = firstName, lastName = lastName, | ||
| avatarUrl = it.url, details = details), id) |
There was a problem hiding this comment.
Repetition, please use data class copy constructor
| val signUpObservable: Single<User> = authService.signUp(signUp).flatMap { | ||
| email = signUp.email | ||
| password = signUp.password | ||
| authService.login(email.nullToEmpty(), password.nullToEmpty()).flatMap { |
There was a problem hiding this comment.
Chaining should not be nested
There was a problem hiding this comment.
Still not resolved. Chaining should not be nested. That's the point of chaining
app/src/main/java/org/fossasia/openevent/general/order/OrderDetailsViewModel.kt
Outdated
Show resolved
Hide resolved
liveHarshit
previously approved these changes
Jul 15, 2019
app/src/main/java/org/fossasia/openevent/general/auth/SignUpViewModel.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/org/fossasia/openevent/general/order/OrderDetailsViewModel.kt
Outdated
Show resolved
Hide resolved
iamareebjamal
requested changes
Jul 15, 2019
iamareebjamal
requested changes
Jul 17, 2019
| val signUpObservable: Single<User> = authService.signUp(signUp).flatMap { | ||
| email = signUp.email | ||
| password = signUp.password | ||
| authService.login(email.nullToEmpty(), password.nullToEmpty()).flatMap { |
There was a problem hiding this comment.
Still not resolved. Chaining should not be nested. That's the point of chaining
|
@iamareebjamal, please review |
iamareebjamal
approved these changes
Jul 26, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details:
Fixes: #2116