Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Event time, price and UI for tickets #2145

Merged
merged 1 commit into from
Jul 20, 2019
Merged

fix: Event time, price and UI for tickets #2145

merged 1 commit into from
Jul 20, 2019

Conversation

liveHarshit
Copy link
Member

@liveHarshit liveHarshit commented Jul 19, 2019 •
edited
Loading

Fixes #2119

  • Set margin b/w ticket name and price
  • Display tickets price with two decimal places
  • Fix event time in tickets fragment

@iamareebjamal iamareebjamal changed the title Fix: Event time, price and UI for tickets fix: Event time, price and UI for tickets Jul 19, 2019
@auto-label auto-label bot added the fix label Jul 19, 2019
@iamareebjamal
Copy link
Member

Add screenshots

nikit19
nikit19 previously approved these changes Jul 19, 2019
View reviewed changes
Copy link
Member

@nikit19 nikit19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good codewise. Always add screenshots for UI changes

anhanh11001
anhanh11001 previously approved these changes Jul 19, 2019
View reviewed changes
@liveHarshit liveHarshit dismissed stale reviews from anhanh11001 and nikit19 via b885d6b July 20, 2019 05:18
@liveHarshit
Copy link
Member Author

Updated

@iamareebjamal iamareebjamal merged commit ad57347 into fossasia:development Jul 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anhanh11001 anhanh11001 anhanh11001 approved these changes

@nikit19 nikit19 nikit19 left review comments

Assignees
No one assigned
Labels
fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix Ui: Tickets, Attendee and search fragment
4 participants
@liveHarshit @iamareebjamal @nikit19 @anhanh11001