feat: Add slide up down animation #2186
Conversation
|
what kind of library should I look for? |
|
https://github.com/bravoborja/ReadMoreTextView
|
|
I didn't any use existing "ReadMoreTextView" library because it is unrelated to the issue and I also find it unnecessary to use a library for that |
|
|
||
| animation.duration = 300 | ||
| startAnimation(animation) | ||
| } |
There was a problem hiding this comment.
I find it unnecessary to write 100 lines of code to do something which is just an enhancement and unrelated to the core working of the project. It can impact performance, and contain bugs, we have to maintain it. 2 months later, nobody will understand the code and will not be able to maintain it. Same thing happened in server where instead of using a well-maintained library, they wrote celery integration by hand. New version of celery came and it broke. If they were using a library, it would have been a matter of bumping the version. That is why we use libraries
Trust me, if I had a library which did 2+2, I'd use that instead of writing 2+2. You don't know how hard it is to maintain code when it is not your core logic and a person who wrote it has stopped maintaining the project and code rot eventually happens and the code has bugs. |
|
updated |
| <LinearLayout | ||
| android:orientation="vertical" | ||
| android:layout_width="match_parent" | ||
| android:layout_height="wrap_content"> | ||
| <ImageView |
Details: - Use external libraries for expandable text view and view container Fixes: #2182
Details:
Fixes: #2182
Screenshots for the change:
