Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Prevent no donation #2251

Merged
merged 1 commit into from
Aug 8, 2019
Merged

fix: Prevent no donation #2251

merged 1 commit into from
Aug 8, 2019

Conversation

anhanh11001
Copy link
Contributor

Details:

  • Disable options to pick donation ticket quantity when no donation is entered

Fixes: #2243

Screenshots for the change:
ezgif-1-6a79ddaac642

@auto-label auto-label bot added the fix label Aug 7, 2019
"fieldPath": "longAbstract",
"columnName": "longAbstract",
"affinity": "TEXT",
"notNull": false
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why changes in this?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reverted

Ishaan28malik
Ishaan28malik previously approved these changes Aug 7, 2019
Copy link
Member

@Ishaan28malik Ishaan28malik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well

Details:
- Disable options to pick donation ticket quantity when no donation is entered

Fixes: #2243
Copy link
Member

@iamareebjamal iamareebjamal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Build Failing

@adityastic
Copy link
Contributor

Build Failing

Travis was having issues this morning, please rerun the build manually from travis @iamareebjamal

@anhanh11001
Copy link
Contributor Author

@iamareebjamal from what I'm seeing here, it is not??? all checks have passed

@iamareebjamal iamareebjamal merged commit 1ad1762 into fossasia:development Aug 8, 2019
@iamareebjamal
Copy link
Member

It was failing when I commented

@ShridharGoel
Copy link
Member

from what I'm seeing here, it is not??? all checks have passed

I had restarted the build, then it passed.

@anhanh11001 anhanh11001 deleted the 2243_no_donation branch August 8, 2019 11:07
liveHarshit pushed a commit to liveHarshit/open-event-attendee-android that referenced this pull request Aug 11, 2019
Details:
- Disable options to pick donation ticket quantity when no donation is entered

Fixes: fossasia#2243
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Donation tickets made with no donation
5 participants