fix: Hide map when no information is present #2266
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Detail: - When event doesn't contain any location details (latitude, longitude), imageMap is hide Fixes: #2256
liveHarshit
reviewed
Aug 9, 2019
| @@ -459,8 +459,7 @@ class EventDetailsFragment : Fragment() { | |||
| // load location to map | |||
| val mapClickListener = View.OnClickListener { startMap(event) } | |||
|
|
|||
| val locationNameIsEmpty = event.locationName.isNullOrEmpty() | |||
| if (!locationNameIsEmpty) { | |||
| if (!event.locationName.isNullOrEmpty() && event.longitude != null && event.latitude != null) { | |||
There was a problem hiding this comment.
What if the only location name is there, the map should display, right?
iamareebjamal
approved these changes
Aug 9, 2019
iamareebjamal
changed the title
liveHarshit
pushed a commit
to liveHarshit/open-event-attendee-android
that referenced
this pull request
Aug 11, 2019
Detail: - When event doesn't contain any location details (latitude, longitude), imageMap is hide Fixes: fossasia#2256
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Detail:
Fixes: #2256