Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Multiple small enhancements in Event Detail Fragment #2294

Merged
merged 1 commit into from
Aug 21, 2019
Merged

fix: Multiple small enhancements in Event Detail Fragment #2294

merged 1 commit into from
Aug 21, 2019

Conversation

anhanh11001
Copy link
Contributor

Detail:

  • use isVisible() Kotlin function
  • Fix some empty space in session card
  • Strip HTML in Sponsor section
  • Add auto link in Speakers Call announcement section
  • Improve network call in Session Fragment
  • Fix clickListener in Session Detail Section

Fixes: #2290

@anhanh11001
Summary: Multiple UI changes in Event Detail Fragment
ec8d1bd 
Detail:
- use isVisible() Kotlin function
- Fix some empty space in session card
- Strip HTML in Sponsor section
- Add auto link in Speakers Call announcement section
- Improve network call in Session Fragment
- Fix clickListener in Session Detail Section

Fixes: #2290
@auto-label auto-label bot added the fix label Aug 21, 2019
@iamareebjamal iamareebjamal merged commit ce78495 into fossasia:development Aug 21, 2019
@anhanh11001 anhanh11001 deleted the 2290_sponsor_session branch August 21, 2019 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nikit19 nikit19 nikit19 approved these changes

@iamareebjamal iamareebjamal iamareebjamal approved these changes

Assignees
No one assigned
Labels
fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Multiples small UI problems in Session and Sponsor Section
3 participants
@anhanh11001 @iamareebjamal @nikit19