fix: App link intent appear when clicking on Terms and Policy Section #2345
Conversation
Is there any problem? |
app/build.gradle
Outdated
| @@ -60,7 +60,7 @@ android { | |||
| buildConfigField "String", "MAPBOX_KEY", '"'+MAPBOX_KEY+'"' | |||
| buildConfigField "String", "STRIPE_API_KEY", '"'+STRIPE_API_TOKEN+'"' | |||
| buildConfigField "String", "PAYPAL_CLIENT_ID", '"'+PAYPAL_CLIENT_ID+'"' | |||
| resValue "string", "FRONTEND_HOST", "eventyay.com" | |||
| resValue "string", "FRONTEND_HOST", "api.eventyay.com" | |||
There was a problem hiding this comment.
I told you to change the API URL for reproducing the issue, for debugging.
There was a problem hiding this comment.
Actually, Default base URL starts with "api.eventyay" and in the intent filter, the host had value "eventyay.com" because of which options of choosing app was coming.
There was a problem hiding this comment.
I changed the API URL for reproducing the error. Do you want it to remain changed or back to initial value?
There was a problem hiding this comment.
You unfortunately, don't understand the issue. Read it again
There was a problem hiding this comment.
@iamareebjamal @liveHarshit If I am correct then the app deep linking feature is not working for the release build of the app and I am supposed to solve this issue.
Please correct me if I am wrong?
There was a problem hiding this comment.
Yes, you're. App link intent should accept the only following type of URLs -
- Event details: https://eventyay.com/e/{event-identifier}
- Reset password: https://eventyay.com/reset-password?token={token}
- Verify email: https://eventyay.com/email/verify?token={token}
For other types like terms and policy URLs, it should not take it as app link intent.
But here you removed the whole feature instead. We are not targeting any type of build. I told you to change frontend host only for testing purposes as all links are with eventyay.com host.
Clear??
There was a problem hiding this comment.
I changed the API URL for reproducing the error. Do you want it to remain changed or back to initial value?
So we send PR after fixing the error, not after reproducing it.
|
@liveHarshit @iamareebjamal I have made changes in my PR. |
|
Have you ensured that normal app linking it working as expected? |
|
@iamareebjamal I have checked it for email verification and it was working properly. |
|
Please test for event and password reset as well |
|
It is working for all the three cases mentioned above. |
Fixes #2292
Changes: Changed the DEFAULT_BASE_URL for release build
GIF for the change: