fix: Similar events collapsing #2391
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liveHarshit
suggested changes
Oct 13, 2019
app/src/main/java/org/fossasia/openevent/general/event/EventDetailsFragment.kt
Outdated
Show resolved
Hide resolved
liveHarshit
changed the title
nikit19
reviewed
Oct 13, 2019
app/src/main/java/org/fossasia/openevent/general/event/EventDetailsFragment.kt
Outdated
Show resolved
Hide resolved
liveHarshit
approved these changes
Oct 17, 2019
rcs10
pushed a commit
to rcs10/open-event-attendee-android
that referenced
this pull request
Jun 18, 2020
* fix: Resolve similar events collapsing issue fossasia#2390 * Remove non assertion operator * Resolve indentation error Signed-off-by: rcs10 <dhanueshrc28@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2390
Changes:
Previously the visibility of the container layout was dependent on the size of the list fetched from the API. So, whenever the list reaches the end of the pagination, due to size 0, the visibility of the layout was set as GONE. Now, I have used a boolean hasSimiliarEvents (initially false) which get updated depending on the size of the list and container layout's visibility depends on this variable. So, even if there are events on any page the variable will be set as true otherwise false. This resolved the issue.
Screenshots for the change:
