Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: list front page restriction in frontpage tab #5598

Merged
merged 3 commits into from
Nov 18, 2020
Merged

fix: list front page restriction in frontpage tab #5598

merged 3 commits into from
Nov 18, 2020

Conversation

maze-runnar
Copy link
Contributor

@maze-runnar maze-runnar commented Nov 13, 2020

Fixes #5110

List all start page restrictions in a subtab on the Admin Settings page here https://eventyay.com/admin/settings -> in https://eventyay.com/admin/settings/frontpage

related #4697

  • In https://eventyay.com/admin/settings add a sub tab "Front Page"
  • Show 3 sections: Featured Events, Upcoming Events, Call for Speakers
  • Below each section list the requirements to be listed in the section (as listed above)

Checklist

  • I have read the Contribution & Best practices Guide.
  • My branch is up-to-date with the Upstream development branch.
  • The acceptance, integration, unit tests and linter pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@vercel
Copy link

vercel bot commented Nov 13, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/eventyay/open-event-frontend/8pdr32em4
✅ Preview: https://open-event-frontend-git-admin-front.eventyay.vercel.app

@codecov
Copy link

codecov bot commented Nov 13, 2020

Codecov Report

Merging #5598 (0f870e4) into development (ed2dd18) will decrease coverage by 0.01%.
The diff coverage is 33.33%.

Impacted file tree graph

@@               Coverage Diff               @@
##           development    #5598      +/-   ##
===============================================
- Coverage        23.75%   23.74%   -0.02%     
===============================================
  Files              498      498              
  Lines             5258     5278      +20     
  Branches            44       47       +3     
===============================================
+ Hits              1249     1253       +4     
- Misses            4003     4017      +14     
- Partials             6        8       +2     
Impacted Files Coverage Δ
app/components/widgets/forms/image-upload.js 22.64% <0.00%> (-0.44%) ⬇️
app/router.js 100.00% <100.00%> (ø)
app/components/tabbed-navigation.js 33.33% <0.00%> (-20.00%) ⬇️
app/components/widgets/forms/link-field.ts 65.21% <0.00%> (-9.79%) ⬇️
app/utils/dictionary/social-media.ts 92.30% <0.00%> (-7.70%) ⬇️
app/models/social-link.js 0.00% <0.00%> (ø)
app/components/forms/orders/order-form.js 0.00% <0.00%> (ø)
app/serializers/event-statistics-general.js 0.00% <0.00%> (ø)
app/components/public/ticket-list.js 19.00% <0.00%> (+0.04%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2ff1f35...87f833a. Read the comment docs.

@maze-runnar
Copy link
Contributor Author

scrnli_11_17_2020_10-31-38 PM

@iamareebjamal
Copy link
Member

All except 1 criteria is working, so please remove the tick from that criteria and we can merge this and add the tick when it starts working

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Frontpage: Limit display of events based on the public ticket availability
2 participants