feat: sort attendee list on the basis of ticket type (#781) #782

AkshayCHD · 2018-03-16T17:05:54Z

Fixes #781 #275

Changes:Add sorting feature to sort attendee list on the basis of ticket type

Screenshots for the change:

open-event-bot · 2018-03-16T17:16:16Z

Hi @AkshayCHD!

It looks like one or more of your builds have failed.
I've added the relevant info below to save you some time.

Build 1615.1 has failed

open-event-bot · 2018-03-16T18:30:02Z

Hi @AkshayCHD!

It looks like one or more of your builds have failed.
I've added the relevant info below to save you some time.

Build 1616.1 has failed

open-event-bot · 2018-03-16T20:36:41Z

Hi @AkshayCHD!

It looks like one or more of your builds have failed.
I've added the relevant info below to save you some time.

Build 1617.1 has failed

AkshayCHD · 2018-03-16T20:52:14Z

@iamareebjamal please review

codecov · 2018-03-16T20:52:30Z

Codecov Report

Merging #782 into development will decrease coverage by 0.28%.
The diff coverage is 0%.

@@                Coverage Diff                @@
##             development     #782      +/-   ##
=================================================
- Coverage          32.52%   32.24%   -0.29%     
  Complexity           449      449              
=================================================
  Files                122      122              
  Lines               3557     3588      +31     
  Branches             127      129       +2     
=================================================
  Hits                1157     1157              
- Misses              2354     2385      +31     
  Partials              46       46

Impacted Files	Coverage Δ	Complexity Δ
...vent/app/core/attendee/list/AttendeesFragment.java	`0% <0%> (ø)`	`0 <0> (ø)`	⬇️
...nt/app/core/attendee/list/StickyHeaderAdapter.java	`0% <0%> (ø)`	`0 <0> (ø)`	⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e91d338...4f8ff6e. Read the comment docs.

iamareebjamal

Use fastadapter for sorting

iamareebjamal · 2018-03-17T03:45:02Z

app/src/main/res/menu/menu_attendees.xml

@@ -19,5 +19,8 @@
                android:title="@string/filter_by_sync" />
        </menu>
    </item>
+    <item android:id="@+id/sort"
+        android:title="@string/sort" />


Don't use explicit dialog box, see above how the filter menu is created

AkshayCHD · 2018-03-17T06:11:36Z

@iamareebjamal sorting in fastadapter requires min api level 24

iamareebjamal · 2018-03-17T06:59:30Z

Where is it written so, it is a library and hence shouldn't have any min API constraint

AkshayCHD · 2018-03-17T17:42:38Z

@iamareebjamal the sort function, which uses comparators to sort adapteritems requires api 24

iamareebjamal · 2018-03-17T18:21:48Z

Can you point to doc reference please

AkshayCHD · 2018-03-18T13:19:21Z

@iamareebjamal the only way to sort lists in fast adapter is as shown here, https://github.com/mikepenz/FastAdapter/blob/6b7b1cf2fe7a6d86ce8eb3ae725470d6477df356/app/src/main/java/com/mikepenz/fastadapter/app/SortActivity.java and in my opinion the already implemented way is better than that. As the method here was not added initially but was later added as in the discussion here mikepenz/FastAdapter#51 in the method we have to make a new comparator and then implement all the methods of the superclass, whereas right now sorting requires only Collection.sort() function which is simply implemented using lambda notation

iamareebjamal · 2018-03-18T15:27:55Z

Comparator can be created as a lamda as well

AkshayCHD · 2018-03-18T19:24:01Z

@iamareebjamal please review

open-event-bot · 2018-03-18T19:26:26Z

Hi @AkshayCHD!

It looks like one or more of your builds have failed.
I've added the relevant info below to save you some time.

Build 1629.1 has failed

AkshayCHD · 2018-03-20T07:56:36Z

@iamareebjamal i have added some new features to my proposal can you review them please https://docs.google.com/document/d/1pkm8zEYxfGR809NOQNMwaMsbh5T4HSmrFcf-4nDNC_w/edit?usp=sharing

iamareebjamal · 2018-03-23T04:00:05Z

@AkshayCHD Please update the PR

open-event-bot · 2018-03-28T14:00:15Z

Hi @AkshayCHD!

It looks like one or more of your builds have failed.
I've added the relevant info below to save you some time.

Build 1743.1 has failed

open-event-bot · 2018-03-28T16:58:10Z

Hi @AkshayCHD!

It looks like one or more of your builds have failed.
I've added the relevant info below to save you some time.

Build 1746.1 has failed

iamareebjamal · 2018-03-29T05:16:37Z

app/src/main/res/menu/menu_attendees.xml

@@ -19,5 +19,15 @@
                android:title="@string/filter_by_sync" />
        </menu>
    </item>
+    <item android:id="@+id/sortAttendee"


Should have an icon

AkshayCHD · 2018-03-29T17:34:15Z

@iamareebjamal please review

iamareebjamal · 2018-03-29T17:37:57Z

app/src/main/res/drawable/ic_filter.xml

@@ -3,5 +3,5 @@
    android:width="24dp"
    android:viewportWidth="24"
    android:viewportHeight="24">
-    <path android:fillColor="#000" android:pathData="M6,13H18V11H6M3,6V8H21V6M10,18H14V16H10V18Z" />
+    <path android:fillColor="#000" android:pathData="M3,2H21V2H21V4H20.92L14,10.92V22.91L10,18.91V10.91L3.09,4H3V2Z" />


Why this change?

open-event-bot · 2018-03-29T17:39:08Z

Hi @AkshayCHD!

It looks like one or more of your builds have failed.
I've added the relevant info below to save you some time.

Build 1766.1 has failed

iamareebjamal · 2018-03-29T17:38:27Z

app/src/main/res/values/strings.xml

@@ -106,6 +106,7 @@
    <string name="create_event">Create Event</string>
    <string name="event_name">Event Name</string>
    <string name="payment_currency">Payment Currency</string>
+    <string name="sort_by_ticket_type">Ticket</string>


Should be ticket

iamareebjamal · 2018-03-29T17:38:46Z

app/src/main/java/org/fossasia/openevent/app/core/attendee/list/AttendeesFragment.java

            default:
                return super.onOptionsItemSelected(item);
        }
    }

+    void sortAttendees(int sortBy) {


Should be private

iamareebjamal · 2018-03-29T17:39:23Z

app/src/main/java/org/fossasia/openevent/app/core/attendee/list/AttendeesFragment.java

+    @Override
+    public void onDestroy() {
+        super.onDestroy();
+        fastAdapter.unregisterAdapterDataObserver(observer);


Check for nulls

AkshayCHD · 2018-03-29T18:03:02Z

@iamareebjamal I have improved the drawable used for filtering, the new one is more relevant to the functionality provided and also is easily distinguishable from the one used for sorting, I have updated the screenshots please have a look

iamareebjamal · 2018-03-29T18:06:01Z

app/src/main/res/values/strings.xml

@@ -106,6 +106,7 @@
    <string name="create_event">Create Event</string>
    <string name="event_name">Event Name</string>
    <string name="payment_currency">Payment Currency</string>
+    <string name="sort_by_ticket">Ticket</string>


Should be ticket

AkshayCHD · 2018-03-29T18:12:45Z

@iamareebjamal please review

open-event-bot · 2018-03-29T18:15:06Z

Hi @AkshayCHD!

It looks like one or more of your builds have failed.
I've added the relevant info below to save you some time.

Build 1770.1 has failed

open-event-bot bot assigned AkshayCHD Mar 16, 2018

open-event-bot bot added the needs-review label Mar 16, 2018

AkshayCHD force-pushed the sort branch from 96a20ae to 2825c6b Compare March 16, 2018 18:22

AkshayCHD force-pushed the sort branch from 2825c6b to 8ab4d1f Compare March 16, 2018 20:29

AkshayCHD force-pushed the sort branch from 8ab4d1f to 89edd17 Compare March 16, 2018 20:42

iamareebjamal requested changes Mar 17, 2018

View reviewed changes

iamareebjamal reviewed Mar 17, 2018

View reviewed changes

AkshayCHD force-pushed the sort branch from 89edd17 to 0959e7a Compare March 18, 2018 19:22

AkshayCHD force-pushed the sort branch from 0959e7a to 977ceb0 Compare March 18, 2018 19:40

fossasia deleted a comment Mar 19, 2018

AkshayCHD force-pushed the sort branch from 41e50f5 to e42db36 Compare March 28, 2018 12:32

fossasia deleted a comment Mar 28, 2018

AkshayCHD force-pushed the sort branch 2 times, most recently from 791509b to fe86d2c Compare March 28, 2018 13:54

AkshayCHD force-pushed the sort branch from 7461226 to 25ce4b3 Compare March 28, 2018 17:15

fossasia deleted a comment Mar 28, 2018

iamareebjamal reviewed Mar 29, 2018

View reviewed changes

AkshayCHD force-pushed the sort branch from 25ce4b3 to c359e8d Compare March 29, 2018 17:32

fossasia deleted a comment Mar 29, 2018

iamareebjamal reviewed Mar 29, 2018

View reviewed changes

iamareebjamal requested changes Mar 29, 2018

View reviewed changes

fossasia deleted a comment Mar 29, 2018

AkshayCHD force-pushed the sort branch from b3abff5 to 30f85a9 Compare March 29, 2018 17:58

fossasia deleted a comment Mar 29, 2018

iamareebjamal requested changes Mar 29, 2018

View reviewed changes

fossasia deleted a comment Mar 29, 2018

AkshayCHD force-pushed the sort branch from 23d8ad6 to 8eb98f2 Compare March 29, 2018 18:10

fossasia deleted a comment Mar 29, 2018

feat: sort attendee list on the basis of ticket type (fossasia#781)

947a2e6

AkshayCHD force-pushed the sort branch from 8eb98f2 to 947a2e6 Compare March 29, 2018 18:25

fossasia deleted a comment Mar 29, 2018

Merge branch 'development' into sort

4f8ff6e

fossasia deleted a comment Mar 29, 2018

iamareebjamal approved these changes Mar 29, 2018

View reviewed changes

open-event-bot bot removed the needs-review label Mar 29, 2018

iamareebjamal merged commit 353d463 into fossasia:development Mar 29, 2018

open-event-bot bot added the ready-to-ship label Mar 29, 2018

iamareebjamal pushed a commit that referenced this pull request Jul 16, 2018

feat: sort attendee list on the basis of ticket type (#781) (#782)

9a08aa6

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: sort attendee list on the basis of ticket type (#781) #782

feat: sort attendee list on the basis of ticket type (#781) #782

AkshayCHD commented Mar 16, 2018 •

edited

Loading

open-event-bot bot commented Mar 16, 2018

open-event-bot bot commented Mar 16, 2018

open-event-bot bot commented Mar 16, 2018

AkshayCHD commented Mar 16, 2018

codecov bot commented Mar 16, 2018 •

edited

Loading

iamareebjamal left a comment

iamareebjamal Mar 17, 2018

AkshayCHD commented Mar 17, 2018

iamareebjamal commented Mar 17, 2018

AkshayCHD commented Mar 17, 2018

iamareebjamal commented Mar 17, 2018

AkshayCHD commented Mar 18, 2018 •

edited

Loading

iamareebjamal commented Mar 18, 2018

AkshayCHD commented Mar 18, 2018

open-event-bot bot commented Mar 18, 2018

AkshayCHD commented Mar 20, 2018 •

edited

Loading

iamareebjamal commented Mar 23, 2018

open-event-bot bot commented Mar 28, 2018

open-event-bot bot commented Mar 28, 2018

iamareebjamal Mar 29, 2018

AkshayCHD commented Mar 29, 2018

iamareebjamal Mar 29, 2018

open-event-bot bot commented Mar 29, 2018

iamareebjamal Mar 29, 2018

iamareebjamal Mar 29, 2018

iamareebjamal Mar 29, 2018

AkshayCHD commented Mar 29, 2018

iamareebjamal Mar 29, 2018

AkshayCHD commented Mar 29, 2018

open-event-bot bot commented Mar 29, 2018

feat: sort attendee list on the basis of ticket type (#781) #782

feat: sort attendee list on the basis of ticket type (#781) #782

Conversation

AkshayCHD commented Mar 16, 2018 • edited Loading

open-event-bot bot commented Mar 16, 2018

open-event-bot bot commented Mar 16, 2018

open-event-bot bot commented Mar 16, 2018

AkshayCHD commented Mar 16, 2018

codecov bot commented Mar 16, 2018 • edited Loading

Codecov Report

iamareebjamal left a comment

Choose a reason for hiding this comment

iamareebjamal Mar 17, 2018

Choose a reason for hiding this comment

AkshayCHD commented Mar 17, 2018

iamareebjamal commented Mar 17, 2018

AkshayCHD commented Mar 17, 2018

iamareebjamal commented Mar 17, 2018

AkshayCHD commented Mar 18, 2018 • edited Loading

iamareebjamal commented Mar 18, 2018

AkshayCHD commented Mar 18, 2018

open-event-bot bot commented Mar 18, 2018

AkshayCHD commented Mar 20, 2018 • edited Loading

iamareebjamal commented Mar 23, 2018

open-event-bot bot commented Mar 28, 2018

open-event-bot bot commented Mar 28, 2018

iamareebjamal Mar 29, 2018

Choose a reason for hiding this comment

AkshayCHD commented Mar 29, 2018

iamareebjamal Mar 29, 2018

Choose a reason for hiding this comment

open-event-bot bot commented Mar 29, 2018

iamareebjamal Mar 29, 2018

Choose a reason for hiding this comment

iamareebjamal Mar 29, 2018

Choose a reason for hiding this comment

iamareebjamal Mar 29, 2018

Choose a reason for hiding this comment

AkshayCHD commented Mar 29, 2018

iamareebjamal Mar 29, 2018

Choose a reason for hiding this comment

AkshayCHD commented Mar 29, 2018

open-event-bot bot commented Mar 29, 2018

AkshayCHD commented Mar 16, 2018 •

edited

Loading

codecov bot commented Mar 16, 2018 •

edited

Loading

AkshayCHD commented Mar 18, 2018 •

edited

Loading

AkshayCHD commented Mar 20, 2018 •

edited

Loading