Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Update order expiry time Admin Only tag #6185

Closed
liveHarshit opened this issue Jul 12, 2019 · 11 comments · Fixed by #6230
Closed

Docs: Update order expiry time Admin Only tag #6185

liveHarshit opened this issue Jul 12, 2019 · 11 comments · Fixed by #6230
Labels

Comments

@liveHarshit
Copy link
Member

image

fossasia/open-event-attendee-android#2104 (comment)

@issue-label-bot
Copy link

Issue-Label Bot is automatically applying the label feature to this issue, with a confidence of 0.83. Please mark this comment with 👍 or 👎 to give our bot feedback!

Links: app homepage, dashboard and code for this bot.

@shreyanshdwivedi
Copy link
Member

On it

@shreyanshdwivedi
Copy link
Member

shreyanshdwivedi commented Jul 12, 2019

@liveHarshit I can retrieve order-expiry-time even without login
This is the code -

if 'Authorization' in request.headers:
            _jwt_required(app.config['JWT_DEFAULT_REALM'])

            if current_user.is_admin or current_user.is_super_admin:
                self.schema = SettingSchemaAdmin
            else:
                self.schema = SettingSchemaNonAdmin
        else:
            self.schema = SettingSchemaPublic

And SettingSchemaPublic has order_expiry_time.
If you go to your browser and hit url - http://localhost:5000/v1/settings then also you can view order-expiry-time in the response (keep server up and running).
I think you're not using dev branch. Please take a look and let me know if you still face any difficulty.

@liveHarshit
Copy link
Member Author

@shreyanshdwivedi Yes I'm also able to get through the browser, will check again the implementation in Android. Now the docs need to be update. 👍

@shreyanshdwivedi
Copy link
Member

Will update the docs :)

@iamareebjamal iamareebjamal changed the title Allow clients to see order expiry time Docs: Update order expiry time Admin Only tag Jul 12, 2019
@kushthedude
Copy link
Member

Will update the docs :)

Why does the client need to see expiry-time?

@iamareebjamal
Copy link
Member

To show to the user

@sameshl
Copy link
Contributor

sameshl commented Jul 23, 2019

@iamareebjamal I want to take this up but I don't exactly understand what I have to do here. Should i change Yes to No in the tab?

@kushthedude
Copy link
Member

@sameshl Feel free to solve the issue.

@sameshl
Copy link
Contributor

sameshl commented Jul 23, 2019

@kushthedude I have to only change the tab value from Yes to No right?

@kushthedude
Copy link
Member

kushthedude commented Jul 23, 2019 via email

iamareebjamal pushed a commit that referenced this issue Jul 23, 2019
changed the tag from `Yes` to `-`

closes #6185
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants