fix: Discount code quantity calculation #6878
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
houndci-bot
reviewed
Mar 7, 2020
|
|
||
| db.session.commit() | ||
|
|
||
| # Attendees associated with the order without discount code should not be counted |
| discount_code = DiscountCodeTicketFactory(tickets_number=5) | ||
| discount_code.tickets.append(ticket) | ||
|
|
||
| order_without_discount = OrderFactory(status='completed') |
| from app.factories.discount_code import DiscountCodeTicketFactory | ||
| from app.models import db | ||
|
|
||
| from app.models.discount_code import DiscountCode |
There was a problem hiding this comment.
'app.models.discount_code.DiscountCode' imported but unused
| @@ -0,0 +1,53 @@ | |||
| from app.api.helpers.ticketing import TicketingManager | |||
| from app.factories.attendee import AttendeeFactory, AttendeeFactoryBase | |||
There was a problem hiding this comment.
'app.factories.attendee.AttendeeFactory' imported but unused
Codecov Report
@@ Coverage Diff @@
## development #6878 +/- ##
===============================================
+ Coverage 66.21% 66.34% +0.13%
===============================================
Files 307 308 +1
Lines 15298 15330 +32
===============================================
+ Hits 10129 10171 +42
+ Misses 5169 5159 -10
Continue to review full report at Codecov.
|
|
Complexity increasing per file
==============================
- tests/all/integration/api/helpers/test_ticketing.py 2
See the complete overview on Codacy |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6879