Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Included tax calculation #7037

Merged
merged 1 commit into from
Jun 1, 2020

Conversation

iamareebjamal
Copy link
Member

@iamareebjamal iamareebjamal commented Jun 1, 2020

Previously, tax was being calculated using wrong formula (same as excluded). Now, it uses correct formula for included tax

@auto-label auto-label bot added the fix label Jun 1, 2020
@codecov
Copy link

codecov bot commented Jun 1, 2020

Codecov Report

Merging #7037 into development will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##           development    #7037   +/-   ##
============================================
  Coverage        60.59%   60.60%           
============================================
  Files              260      260           
  Lines            12885    12886    +1     
============================================
+ Hits              7808     7809    +1     
  Misses            5077     5077           
Impacted Files Coverage Δ
app/api/helpers/order.py 66.12% <100.00%> (+0.27%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e743f07...82d355e. Read the comment docs.

@iamareebjamal iamareebjamal merged commit 91073a3 into fossasia:development Jun 1, 2020
@iamareebjamal iamareebjamal deleted the order-amount-tax branch June 1, 2020 02:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant