Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Add update custom form test #7065

Merged
merged 1 commit into from
Jun 21, 2020
Merged

Conversation

iamareebjamal
Copy link
Member

No description provided.

Also rename test file so pytest registers it
@@ -54,25 +73,25 @@ def test_assigning_old_form_name(db):
event=event, field_identifier='longAbstract', form='session', type='text'
)
none_custom_form = CustomForms(
event=event, field_identifier='showNumber', form='attendee', type='text'
event=event, field_identifier='showNumber', name='Show Number', form='attendee', type='text'

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

line too long (100 > 90 characters)

@niranjan94
Copy link
Member

Codacy Here is an overview of what got changed by this pull request:

Complexity increasing per file
==============================
- tests/all/integration/models/test_custom_forms.py  11
         

Clones added
============
- tests/all/integration/models/test_custom_forms.py  2
         

See the complete overview on Codacy

@codecov
Copy link

codecov bot commented Jun 21, 2020

Codecov Report

Merging #7065 into development will increase coverage by 0.04%.
The diff coverage is 100.00%.

Impacted file tree graph

@@               Coverage Diff               @@
##           development    #7065      +/-   ##
===============================================
+ Coverage        61.61%   61.66%   +0.04%     
===============================================
  Files              260      260              
  Lines            12914    12915       +1     
===============================================
+ Hits              7957     7964       +7     
+ Misses            4957     4951       -6     
Impacted Files Coverage Δ
app/models/custom_form.py 97.82% <100.00%> (+13.38%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e73bf88...14feb7e. Read the comment docs.

@iamareebjamal iamareebjamal merged commit e8e6910 into development Jun 21, 2020
@iamareebjamal iamareebjamal deleted the custom-form/test branch June 21, 2020 04:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants