fix: Fail order status transition to pending if incomplete attendee info

[Haider8]

Fixes #7069

Short description of what this resolves:

Right now order status can be transitioned to pending even if corresponding attendees have incomplete info, which is incorrect.

Changes proposed in this pull request:

Fail order status transitioning to pending if incomplete attendee info

Checklist

• I have read the Contribution & Best practices Guide and my PR follows them.
• My branch is up-to-date with the Upstream development branch.
• The unit tests pass locally with my changes
• I have added tests that prove my fix is effective or that my feature works
• I have added necessary documentation (if appropriate)

• All the functions created/modified in this PR contain relevant docstrings.

[codecov]

Codecov Report

Merging #7113 into development will increase coverage by 0.04%.
The diff coverage is 100.00%.

@@               Coverage Diff               @@
##           development    #7113      +/-   ##
===============================================
+ Coverage        62.80%   62.84%   +0.04%     
===============================================
  Files              262      262              
  Lines            13005    13011       +6     
===============================================
+ Hits              8168     8177       +9     
+ Misses            4837     4834       -3     

Impacted Files	Coverage Δ
app/api/orders.py	40.97% <100.00%> (+1.71%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3edde45...b40b1bb. Read the comment docs.

[iamareebjamal]

Can be completed or placed as well

[Haider8]

So should I just make this data.get('status') != 'initializing' ?

[iamareebjamal]

No, because this should not run order is being cancelled.

[iamareebjamal]

Please test manually that placed orders and order cancellation is working using the frontend

[iamareebjamal]

You have added tests for failure case, great. Also add tests for success case, where attendees have correct data and order is successfully changed to pending state. Just adding for complex custom forms is enough

[Haider8]

Also add tests for success case, where attendees have correct data and order is successfully changed to pending state

Will do this once I cover placed and completed also in failure test

[iamareebjamal]

That'd be repetition of test logic. Just use pending in one test and placed in another and that'd be enough IMO

I'm talking about the current 2 failure test cases

[iamareebjamal]

Add success case as well

[niranjan94]

Here is an overview of what got changed by this pull request:

Complexity increasing per file
==============================
- tests/all/integration/api/helpers/order/test_edit_order.py  3
- app/api/orders.py  2
         

Clones added
============
- tests/all/integration/api/helpers/order/test_edit_order.py  4
         

See the complete overview on Codacy