Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(docs): Add steps to configure pre-commit hooks #7214

Merged
merged 1 commit into from
Aug 18, 2020
Merged

chore(docs): Add steps to configure pre-commit hooks #7214

merged 1 commit into from
Aug 18, 2020

Conversation

blossom2017
Copy link
Contributor

Fixes #6862

Short description of what this resolves:

Added a step to configure pre-commit hooks in local installation.

Changes proposed in this pull request:

Checklist

  • I have read the Contribution & Best practices Guide and my PR follows them.
  • My branch is up-to-date with the Upstream development branch.
  • The unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • All the functions created/modified in this PR contain relevant docstrings.

@codecov
Copy link

codecov bot commented Aug 15, 2020

Codecov Report

Merging #7214 into development will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##           development    #7214   +/-   ##
============================================
  Coverage        62.98%   62.98%           
============================================
  Files              259      259           
  Lines            13042    13042           
============================================
  Hits              8214     8214           
  Misses            4828     4828           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fa07f62...5c33989. Read the comment docs.


```sh
pip install pre-commit
```
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This shouldn't be necessary as pre-commit in present in requirements

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's correct. Will remove, I had added it in case of errors.

@iamareebjamal iamareebjamal changed the title Added steps to configure pre-commit hooks in Local Installation chore(docs): Add steps to configure pre-commit hooks in Local Installation Aug 18, 2020
@auto-label auto-label bot added the docs label Aug 18, 2020
@iamareebjamal iamareebjamal changed the title chore(docs): Add steps to configure pre-commit hooks in Local Installation chore(docs): Add steps to configure pre-commit hooks Aug 18, 2020
@iamareebjamal iamareebjamal merged commit c6b6d20 into fossasia:development Aug 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Document about configuring pre-commit on local installation
2 participants