Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Only prevent fulfilled or pending order users from deletion #7394

Merged
merged 1 commit into from
Oct 30, 2020

Conversation

iamareebjamal
Copy link
Member

@iamareebjamal iamareebjamal commented Oct 30, 2020

@auto-label auto-label bot added the fix label Oct 30, 2020
@codecov
Copy link

codecov bot commented Oct 30, 2020

Codecov Report

Merging #7394 into development will increase coverage by 0.00%.
The diff coverage is 57.14%.

Impacted file tree graph

@@             Coverage Diff              @@
##           development    #7394   +/-   ##
============================================
  Coverage        64.54%   64.54%           
============================================
  Files              262      262           
  Lines            13246    13252    +6     
============================================
+ Hits              8549     8553    +4     
- Misses            4697     4699    +2     
Impacted Files Coverage Δ
app/api/users.py 30.76% <57.14%> (+1.22%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6b504f7...ab1db20. Read the comment docs.

@iamareebjamal iamareebjamal merged commit 01d5972 into development Oct 30, 2020
@iamareebjamal iamareebjamal deleted the user-delete-order branch October 30, 2020 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Delete Account: Admin and User themselves Not Able to Delete Account
1 participant