Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Allow organizer info links #7404

Merged
merged 1 commit into from
Nov 2, 2020

Conversation

Soumi150
Copy link
Contributor

@Soumi150 Soumi150 commented Nov 2, 2020

Fixes fossasia/open-event-frontend#5344

Short description of what this resolves:

Organizer info links can be saved now.

Checklist

  • I have read the Contribution & Best practices Guide and my PR follows them.
  • My branch is up-to-date with the Upstream development branch.
  • The unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • All the functions created/modified in this PR contain relevant docstrings.

@codecov
Copy link

codecov bot commented Nov 2, 2020

Codecov Report

Merging #7404 into development will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##           development    #7404   +/-   ##
============================================
  Coverage        64.74%   64.74%           
============================================
  Files              262      262           
  Lines            13235    13235           
============================================
  Hits              8569     8569           
  Misses            4666     4666           
Impacted Files Coverage Δ
app/models/event.py 78.73% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5459387...5592ba4. Read the comment docs.

@iamareebjamal iamareebjamal changed the title save organizer info links fix: Allow organizer info links Nov 2, 2020
@auto-label auto-label bot added the fix label Nov 2, 2020
@iamareebjamal
Copy link
Member

You don't add # when you enter an issue URL

@iamareebjamal iamareebjamal merged commit 7496ef7 into fossasia:development Nov 2, 2020
@iamareebjamal
Copy link
Member

Great work picking up the project so quickly

@Soumi150 Soumi150 deleted the change1 branch November 2, 2020 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wizard Step 1: Organizer Info Links are not saved
2 participants