fix: make annoucement filed in speakers call nullable #7435
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| def upgrade(): | ||
| # ### commands auto generated by Alembic - please adjust! ### | ||
| op.alter_column('speakers_calls', 'announcement', |
There was a problem hiding this comment.
After this line, please add statement for converting empty string to null as well
app/api/schema/speakers_calls.py
Outdated
| @@ -54,7 +54,7 @@ def validate_date(self, data, original_data): | |||
| # "speakers-call ends-at should be before event starts-at") | |||
|
|
|||
| id = fields.Str(dump_only=True) | |||
| announcement = fields.Str(required=True) | |||
| announcement = fields.Str(required=False) | |||
There was a problem hiding this comment.
Should be allow_none=True
Codecov Report
@@ Coverage Diff @@
## development #7435 +/- ##
============================================
Coverage 65.29% 65.29%
============================================
Files 265 265
Lines 13217 13217
============================================
Hits 8630 8630
Misses 4587 4587
Continue to review full report at Codecov.
|
|
Missing #7435 (comment) |
yes, I don't exactly know how to do that. Trying to find |
|
|
iamareebjamal
approved these changes
Nov 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes fossasia/open-event-frontend#5578
Checklist
developmentbranch.