fix: if ticket is not available for sale ,don't show event #7443
Conversation
Codecov Report
@@ Coverage Diff @@
## development #7443 +/- ##
===============================================
- Coverage 65.28% 65.27% -0.01%
===============================================
Files 265 265
Lines 13223 13224 +1
===============================================
Hits 8632 8632
- Misses 4591 4592 +1
Continue to review full report at Codecov.
|
app/api/events.py
Outdated
| @@ -858,7 +858,7 @@ def query(self, view_kwargs): | |||
| Event.event_type_id != None, | |||
| Event.event_topic_id != None, | |||
| Event.event_sub_topic_id != None, | |||
| Event.tickets.any(and_(Ticket.deleted_at == None, Ticket.is_hidden == False, Ticket.sales_ends_at > current_time)), | |||
| Event.tickets.any(and_(Ticket.deleted_at == None, Ticket.is_hidden == False, Ticket.sales_ends_at > current_time, Ticket.is_available == True)), | |||
There was a problem hiding this comment.
is_available is not a column. It's a computed property. It doesn't work like this
There was a problem hiding this comment.
the query that is written in is_available property is that right for the condition?can that query be written here again for this work?
There was a problem hiding this comment.
But please run and confirm before committing. Just visit /v1/events/upcoming to verify
| @@ -858,7 +859,7 @@ def query(self, view_kwargs): | |||
| Event.event_type_id != None, | |||
| Event.event_topic_id != None, | |||
| Event.event_sub_topic_id != None, | |||
| Event.tickets.any(and_(Ticket.deleted_at == None, Ticket.is_hidden == False, Ticket.sales_ends_at > current_time, Ticket.is_available == True)), | |||
| Event.tickets.any(and_(Ticket.deleted_at == None, Ticket.is_hidden == False, Ticket.sales_ends_at > current_time, Ticket.quantity > get_sold_and_reserved_tickets_count(Ticket.id))), | |||
There was a problem hiding this comment.
Won't work. This is not a python loop, only allowed operations here are sqlalchemy scalar and join type operations
There was a problem hiding this comment.
Please verify by running before submitting
There was a problem hiding this comment.
it's working, I have checked it
There was a problem hiding this comment.
I have an event, it has two tickets and 1 ticket of each type is sold.then after applying above I edited event and changes ticket number to 1 of both events then the event is not on the front page anymore. Then i changed ticket numbers for one ticket to one and for another ticket to 100. Then event is showing on front page.
There was a problem hiding this comment.
Hmm, yes, it'll work indeed. But I'll have to check if the query is efficient. Sorry for not noticing Ticket.id instead of ticket.id
There was a problem hiding this comment.
Doesn't work, it statically returns all reserved and sold tickets and compares ticket quantity with it
There was a problem hiding this comment.
get_sold_and_reserved_tickets_count(Ticket.id) what is meaning of passing ticked.id here?
There was a problem hiding this comment.
all reserved and sold tickets for a ticket ?
There was a problem hiding this comment.
It won't work because it expects a ticket ID. Passing Ticket.id just returns all tickets sold count
Fixes fossasia/open-event-frontend#5110
Checklist
developmentbranch.