Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: required twitter link to show on upcoming event #7455

Merged
merged 2 commits into from
Nov 17, 2020
Merged

fix: required twitter link to show on upcoming event #7455

merged 2 commits into from
Nov 17, 2020

Conversation

maze-runnar
Copy link
Contributor

Fixes fossasia/open-event-frontend#4697
Upcoming Events

  • other than that there are the following requirements for events to show up here (if they are not promoted). The event should have
    • a Twitter link added

Checklist

  • I have read the Contribution & Best practices Guide and my PR follows them.
  • My branch is up-to-date with the Upstream development branch.
  • The unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • All the functions created/modified in this PR contain relevant docstrings.

@auto-label auto-label bot added the fix label Nov 17, 2020
@codecov
Copy link

codecov bot commented Nov 17, 2020

Codecov Report

Merging #7455 (4c6a12e) into development (b0a90f0) will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##           development    #7455      +/-   ##
===============================================
+ Coverage        65.34%   65.36%   +0.02%     
===============================================
  Files              265      265              
  Lines            13239    13234       -5     
===============================================
  Hits              8651     8651              
+ Misses            4588     4583       -5     
Impacted Files Coverage Δ
app/api/events.py 38.91% <ø> (ø)
app/api/helpers/scheduled_jobs.py 61.26% <0.00%> (+2.08%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b0a90f0...c9771c8. Read the comment docs.

@@ -859,6 +859,7 @@ def query(self, view_kwargs):
Event.event_topic_id != None,
Event.event_sub_topic_id != None,
Event.tickets.any(and_(Ticket.deleted_at == None, Ticket.is_hidden == False, Ticket.sales_ends_at > current_time)),
Event.social_link.any(and_(SocialLink.name=="twitter"))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why and_?

@iamareebjamal iamareebjamal merged commit 247e9bf into fossasia:development Nov 17, 2020
@maze-runnar maze-runnar deleted the restriction branch December 27, 2020 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Front Page: Standardize Logic and Admin Control to list events (promoted, featured, cfs etc.) on start page
2 participants