Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Remove ability to delete orders #7460

Merged
merged 1 commit into from
Nov 22, 2020

Conversation

codedsun
Copy link
Contributor

Fixes #7423

Short description of what this resolves:

feat: Remove soft deletion from Order Schema, Delete endpoint removed

Changes proposed in this pull request:

Checklist

  • I have read the Contribution & Best practices Guide and my PR follows them.
  • My branch is up-to-date with the Upstream development branch.
  • The unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • All the functions created/modified in this PR contain relevant docstrings.

@auto-label auto-label bot added the feature label Nov 21, 2020
@iamareebjamal
Copy link
Member

Model not changed, no migration created, no query changed

@codedsun codedsun force-pushed the soft-deletion branch 3 times, most recently from f93a116 to 80fb121 Compare November 21, 2020 16:29
@codedsun
Copy link
Contributor Author

@iamareebjamal - review now!

@codecov
Copy link

codecov bot commented Nov 22, 2020

Codecov Report

Merging #7460 (847dc8e) into development (4c8922b) will increase coverage by 0.01%.
The diff coverage is 77.77%.

Impacted file tree graph

@@               Coverage Diff               @@
##           development    #7460      +/-   ##
===============================================
+ Coverage        65.39%   65.40%   +0.01%     
===============================================
  Files              265      265              
  Lines            13236    13229       -7     
===============================================
- Hits              8656     8653       -3     
+ Misses            4580     4576       -4     
Impacted Files Coverage Δ
app/api/attendees.py 56.55% <ø> (ø)
app/api/helpers/order.py 63.04% <0.00%> (ø)
app/models/discount_code.py 94.00% <ø> (ø)
app/api/orders.py 43.73% <66.66%> (+0.34%) ⬆️
app/api/schema/orders.py 96.82% <100.00%> (-0.05%) ⬇️
app/models/order.py 88.37% <100.00%> (-0.14%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4c8922b...847dc8e. Read the comment docs.

@iamareebjamal iamareebjamal changed the title feat: Remove soft deletion from Order Schema, Delete endpoint removed fix: Remove ability to delete orders Nov 22, 2020
@auto-label auto-label bot added fix and removed feature labels Nov 22, 2020
@iamareebjamal iamareebjamal merged commit e2d560d into fossasia:development Nov 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Prevent order from being deleted
2 participants