chore: Change tests to circle CI #7463

codedsun · 2020-11-24T16:50:25Z

No description provided.

iamareebjamal · 2020-11-24T18:33:43Z

.circleci/config.yml

+                command: bash <(curl -s https://codecov.io/bash)
+                when: on_success
+          - run:
+                command: bash scripts/push_api_docs.sh


Use 2 spaces for indentation

.circleci/config.yml

iamareebjamal · 2020-11-24T18:35:56Z

.circleci/config.yml

+          - checkout
+
+          - run:
+                command: ./scripts/test_db.sh


DB and redis services are missing

iamareebjamal · 2020-11-25T15:11:30Z

.circleci/config.yml

+                SECRET_KEY: super secret key
+                PATH: $PATH:${HOME}/google-cloud-sdk/bin
+                DATABASE_URL: postgresql://test@localhost:5433/test
+                TEST_DATABASE_URL: postgresql://test@localhost:5433/test


Don't know where the env is coming from. Match dredd job

env was set in travis file, I copied them

iamareebjamal · 2020-11-25T15:11:49Z

.circleci/config.yml

+                l- v1.3-dependencies-
+
+          - run:
+              command: ./scripts/test_db.sh


Not needed in dredd, not needed here

iamareebjamal · 2020-11-25T15:12:06Z

.circleci/config.yml

+              command: bash <(curl -s https://codecov.io/bash)
+              when: on_success
+          - run:
+              command: bash scripts/push_api_docs.sh


Won't work, remove

iamareebjamal · 2020-11-25T15:12:27Z

.circleci/config.yml

+            branches:
+                only:
+                  - master
+                  - development


Remove the filters for now

iamareebjamal · 2020-11-25T15:58:05Z

https://app.circleci.com/pipelines/github/fossasia/open-event-server/1397/workflows/8463ea6e-acd8-4ac6-9e36-34154623454c/jobs/5498

iamareebjamal · 2020-11-25T16:00:00Z

.circleci/config.yml

+            environment:
+              APP_CONFIG: config.TestingConfig
+              DATABASE_URL: postgresql://postgres@localhost/test
+              TEST_DATABASE_URL: postgresql://postgres@localhost/test


You're still using wrong indentation and mixing and matching the amount of spaces. You can literally copy and paste the dredd job section and make edits. And please turn off auto indentation of your IDE.

Use vim if the IDE is not stopping "intelligently" adding random indentation of spaces which it thinks is correct

IDE was pycharm was auto indenting on commit

codedsun · 2020-11-25T16:44:49Z

@iamareebjamal - Circle Ci pytest shows

#!/bin/bash -eo pipefail
pytest tests -v --cov=.
/bin/bash: pytest: command not found

iamareebjamal · 2020-11-25T16:53:55Z

https://github.com/fossasia/open-event-server/pull/7463/files#diff-78a8a19706dbd2a4425dd72bdab0502ed7a2cef16365ab7030a5a0588927bf47R77

iamareebjamal · 2020-11-25T16:54:55Z

venv is not activated. Look at dredd or pytype job

.circleci/config.yml

auto-label bot added the feature label Nov 24, 2020

iamareebjamal reviewed Nov 24, 2020

View reviewed changes

.circleci/config.yml Outdated Show resolved Hide resolved

iamareebjamal reviewed Nov 24, 2020

View reviewed changes

.circleci/config.yml Outdated

- checkout

- run:

command: ./scripts/test_db.sh

Copy link

Member

iamareebjamal Nov 24, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DB and redis services are missing

codedsun force-pushed the circleci branch 2 times, most recently from 65a9d5d to adb4a87 Compare November 25, 2020 15:04