Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Oscilloscope: Range does not change, when option is chosen #2099

Closed
mariobehling opened this issue Feb 3, 2020 · 11 comments · Fixed by #2552
Closed

Oscilloscope: Range does not change, when option is chosen #2099

mariobehling opened this issue Feb 3, 2020 · 11 comments · Fixed by #2552
Labels
Bug Unexpected problem or unintended behavior in app Codeheat

Comments

@mariobehling
Copy link
Member

mariobehling commented Feb 3, 2020

The Oscilloscope has the option to change the range, e.g. of the Voltage display. This is currently not working. There is no visual change in the app if the user changes the range.

  • Th setting sensitivity doesn't work, it is always +-16V

Screenshot_20200203_133437_io pslab

@mariobehling mariobehling added the Bug Unexpected problem or unintended behavior in app label Feb 3, 2020
@991rajat
Copy link
Contributor

991rajat commented Feb 3, 2020

Works fine on my device.
GIF-200203_232341

@marcnause
Copy link
Contributor

marcnause commented Feb 4, 2020

It works if the channel is selected (check mark is set). It does not work if the channel is not selected.

If the expected behaviour is that the range can only be changed if the channel is selected, then I would expect the range selection to be disabled if the channel is not selected. This would provide a visual hint to the user.

Also the range does not change if:

  1. the channel is not selected
  2. a different range is selected
  3. the channel is selected

@991rajat
Copy link
Contributor

991rajat commented Feb 5, 2020

Still in my device.
If the channel is not selected -> changing range changes the graph.
If the channel is selected -> changing range changes the graph.
I'm not able to get it what bug is. Does it require hardware?

@marcnause
Copy link
Contributor

marcnause commented Feb 6, 2020

It may depend on the Android API level.

It works as pictured by @991rajat on my device with Android 9 (Fairphone 2, LineageOS), but if I use my test device with Android 7 (Motorola Moto X Play, /e/) I get the behaviour as described by @mariobehling.

Today it works on the device which it did not work on yesterday. 😕

@991rajat
Copy link
Contributor

991rajat commented Feb 9, 2020

@Low012, Yes I also not able to reproduce the error.

@kartikeysaran
Copy link
Contributor

Can i take up this issue

@AnishaSingh0118
Copy link

may i work on this issue?

@kartikeysaran
Copy link
Contributor

Sure @AnishaSingh0118 go ahead !

@AnishaSingh0118
Copy link

Sure @AnishaSingh0118 go ahead !

Thanks 😊

@marcnause
Copy link
Contributor

I had a quick look at the issue again. I think it is only reproducable with the hardware. If no signal is displayed in the oscillosocope screen, changing the range works on my device. Once a signal is displayed, the range always resets to +/- 16V

@marcnause
Copy link
Contributor

I tested again with the latest development version of the app (5d6b449) and a v6 board. The problem still exists.

marcnause added a commit to marcnause/pslab-android that referenced this issue Sep 22, 2024
marcnause added a commit to marcnause/pslab-android that referenced this issue Oct 6, 2024
marcnause added a commit to marcnause/pslab-android that referenced this issue Nov 2, 2024
marcnause added a commit to marcnause/pslab-android that referenced this issue Nov 3, 2024
marcnause added a commit to marcnause/pslab-android that referenced this issue Nov 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Unexpected problem or unintended behavior in app Codeheat
Projects
None yet
5 participants