WIP #1719 layout to control servo of robotic arm created #1732
Conversation
|
This is illogical. Please refer to the picture below. Some servos can move 180 degress, some 360 degrees. We can go into detail here later. But, please implement circles.
|
|
|
|
@mariobehling i was thinking we had servo that rotates 0-180 degress that's why i made this design . I will change it and make a new layout today :) |
|
@mariobehling @CloudyPadmal @adityastic kindly have a look at this new layout |
|
@mariobehling @CloudyPadmal kindly have a look the new layout in previous comments. Thanks |
|
Is it possible to enter the numbers manually as well by tapping on the number field? Please ensure this is working too. |
|
@mariobehling right now I haven't added that. I was waiting for you to confirm the basic layout, after that i will add additional features |
|
Thanks. I think the basic layout is good. I see that you introduce a new color in the app. I don't remember that any other instrument uses blue. But, we can work on details later. Please implement the direct number entering functionality. After that please continue working on the instrument. Details are here: #1734 |
|
You can refer to the knobs used at Power Source instrument, also please note codacy |
|
@mariobehling @CloudyPadmal @cweitat I have created a new Layout for the servo controller. I have made the layout in a way that user won't need to scroll make it convenient to control the servos . Also i have made the parameters of the layouts dynamic so it would adjust based on device screen size. The drag and drop of the servo is working fine as seen in gif. I will make the timeline more precise in another PR. kindly have a look
|
|
@mariobehling since i have changed the whole layout, i think it would be better not to split this PR. I will make separate PRs for now onward changes |
|
@mariobehling regarding the editable degree values, i am still working on it, because keyboard in the landscape mode is not responding very well.But i will figure out it really soon. |
|
@neel1998 looks great |
|
Thank you. Let's get other parts done in follow up PRs. |
…sasia#1732) * layout to control servo of robotic arm ceated * new layout created with circular seekbars * started working on drag and drop feature for robotic arm * drag and drop of servo controllers working, timeline and UI needs to be changed * timeline layout created, timeline controlls panel added
4 participants
Fixes #1719
Changes: Created a layout to control servo
Screenshot/s for the changes:
Checklist: [Please tick following check boxes with
[x]if the respective task is completed]strings.xml,dimens.xmlandcolors.xmlwithout hard-coding themstrings.xml,dimens.xmlorcolors.xmlAPK for testing:
robotic_arm.zip
@CloudyPadmal @mariobehling @adityastic kindly have a look at this. I thought it would be much easier to control 4 servo in landscape mode , that's why implemented this layout. As @mariobehling suggested i have added circular view to control angle of servo