Thermometer working added and crash fixed #1754

ho-dor · 2019-05-28T21:16:14Z

Fixes #1750 #1752

Changes: Added backend code for thermometer .

Screenshot/s for the changes:

Checklist: [Please tick following check boxes with [x] if the respective task is completed]

I have used resources from strings.xml, dimens.xml and colors.xml without hard-coding them
No modifications done at the end of resource files strings.xml, dimens.xml or colors.xml
I have reformatted code in every file included in this PR [CTRL+ALT+L]
My code does not contain any extra lines or extra spaces
I have requested reviews from other members

APK for testing:
app-debug.zip

app/src/main/java/io/pslab/fragment/ThermometerDataFragment.java

CloudyPadmal

Make sure all the wordings have been replaced correctly when copying another class as whole. It might lead to errors. Only make the PR when it is clean and ready. Fixing these kind of stuff is not part of review.

CloudyPadmal · 2019-05-29T02:29:59Z

app/src/main/res/layout/activity_thermometer.xml

+                    android:padding="15dp"
+                    app:sv_speedTextColor="@color/black"
+                    app:sv_speedTextPosition="BOTTOM_CENTER"
+                    app:sv_speedTextSize="@dimen/lux_display_font_size"


Can you make separate variables for thermometer replacing the luxs?

No . I kept it the same knowigly because the dimen value are going to be same eventually in UI but I will change it if that is better

Yes, all needs to be changed. The real reason why we are using resources instead of hard-coded values is that, it will be easier and practical to make modifications from one place. Putting luxmeter dimensions is in fact similar to hard-coding.

CloudyPadmal · 2019-05-29T02:30:21Z

app/src/main/res/values/strings.xml

    <string name="thermometer_bottom_sheet_text">Thermometer instrument is used to measure ambient temprature. It can be measured using inbuilt ambient temprature sensor or through SHT21.</string>
    <string name="thermometer_bottom_sheet_desc">Thermometer instrument is used to measure ambient temprature. It can be measured using inbuilt ambient temprature sensor or through SHT21.</string>
    <string name="no_thermometer_sensor">Device does not have Thermometer Sensor</string>
+    <string name="thermo_unit">F</string>


We'll use Celcius

And let user select which unit want from configurations

Yes , I am going to add that functionality . I just wanted to confirm it works or not till here.

I was referring to units here. Throughout the app we are using Metric units, not imperial

CloudyPadmal · 2019-05-29T02:31:20Z

app/src/main/java/io/pslab/fragment/ThermometerDataFragment.java

+
+                count++;
+                sum += entry.getY();
+                statMean.setText(String.format(Locale.getDefault(), PSLabSensor.LUXMETER_DATA_FORMAT, (sum / count)));


All these Lux stuff need to be thermo related

neel1998

Do we need to have max value to be 10000 F? It seems too high

CloudyPadmal · 2019-05-29T08:14:11Z

@neel1998 definitely no. @ho-dor check the datasheet of the sensor and set the max value to the maximum temperature value in that.

CloudyPadmal · 2019-05-29T08:15:10Z

Besides, i think a gauge is not a good way to represent data in a thermometer. We can implement some color bar instead. Please look into this @ho-dor . Thanks.

ho-dor · 2019-05-29T09:20:53Z

Besides, i think a gauge is not a good way to represent data in a thermometer. We can implement some color bar instead. Please look into this @ho-dor . Thanks.

How about we change the background of gauge as the temp changes, like make it green for low temp and red for higher temp ?

CloudyPadmal · 2019-05-29T09:28:09Z

Besides, i think a gauge is not a good way to represent data in a thermometer. We can implement some color bar instead. Please look into this @ho-dor . Thanks.

How about we change the background of gauge as the temp changes, like make it green for low temp and red for higher temp ?

Ok for now. Blue for low temps and red for high temps

ho-dor · 2019-05-29T13:34:54Z

@neel1998 @CloudyPadmal please check

CloudyPadmal · 2019-05-30T06:03:43Z

app/src/main/java/io/pslab/fragment/ThermometerDataFragment.java

 import android.os.Handler;
 import android.support.annotation.NonNull;
-import android.support.annotation.Nullable;
+import android.support.v14.preference.PreferenceFragment;


Codacy complains this as unused

CloudyPadmal · 2019-05-30T06:10:54Z

Rest looks ok. We can progress from here

neel1998 · 2019-05-30T06:11:53Z

Looks ok to me as well

ho-dor · 2019-05-30T07:04:33Z

codacy resolved

ho-dor · 2019-05-30T07:17:17Z

Once this gets merged , I will make a PR for #1756. @CloudyPadmal @neel1998

ho-dor · 2019-05-30T08:37:51Z

I have changed the sensor to SHT21 as that is more suitable for this purpose.

neel1998 · 2019-05-30T09:21:36Z

@ho-dor there is still one unused import in codacy. Remove it in this PR or remember to remove in next one. Also can you send the latest apk once to test

ho-dor · 2019-05-30T10:17:37Z

@neel1998 check

neel1998 · 2019-05-30T10:19:17Z

Can you comment the apk file here?

ho-dor · 2019-05-30T10:21:18Z

Can you comment the apk file here?

The apk file isn't supported to upload here . I have added the latest zip of apk in PR

neel1998 · 2019-05-30T10:29:53Z

The graph is acting weirdly. Please look at the gif. It goes blank after a while. Please look at the barometer graph. It seems to be working okay

ho-dor · 2019-05-30T11:30:36Z

I have increased the range on x-axis and the graph is more like lux meter. I am unable to understand the graph of baro meter as the max value that pressure can reach is 2 according to the range but the graph only shows till 0.45 atm on y-axis.

neel1998 · 2019-05-30T12:18:39Z

This has nothing to do with range, the x - axis should increment every second, which is not happening in the thermometer, also the graph going blank after a while is also not an issue of range

ho-dor · 2019-05-30T12:27:24Z

This has nothing to do with range, the x - axis should increment every second, which is not happening in the thermometer, also the graph going blank after a while is also not an issue of range

I have set the graph updation period to 100 ms in place of 1000 ms that is why it is getting updated quick , but the graph going blank is because of the x-axis range that I have set to 800 now , if you will see , now the graph continues till 800 s earlier it was till 80 s.

neel1998 · 2019-05-30T12:30:01Z

So have you changed to 1000 ms?

ho-dor · 2019-05-30T12:34:23Z

Yes , check the updated apk

neel1998 · 2019-05-30T12:46:21Z

looks good now

ho-dor force-pushed the development branch 2 times, most recently from e2c6c73 to f3fe57e Compare May 28, 2019 21:31

ho-dor mentioned this pull request May 28, 2019

fix:thermometer crash fixed #1753

Closed

5 tasks

adityastic reviewed May 29, 2019

View reviewed changes

app/src/main/java/io/pslab/fragment/ThermometerDataFragment.java Show resolved Hide resolved

CloudyPadmal requested changes May 29, 2019

View reviewed changes

neel1998 suggested changes May 29, 2019

View reviewed changes

ho-dor force-pushed the development branch from f3fe57e to 7de69cc Compare May 29, 2019 13:31

CloudyPadmal requested changes May 30, 2019

View reviewed changes

ho-dor force-pushed the development branch from 7de69cc to c4a2733 Compare May 30, 2019 07:03

CloudyPadmal approved these changes May 30, 2019

View reviewed changes

ho-dor force-pushed the development branch from c4a2733 to b9bf2c5 Compare May 30, 2019 08:36

CloudyPadmal requested a review from neel1998 May 30, 2019 08:52

ho-dor force-pushed the development branch from b9bf2c5 to 5a75f79 Compare May 30, 2019 10:16

ho-dor force-pushed the development branch from 5a75f79 to 65bac69 Compare May 30, 2019 11:28

Thermometer working added and crash fixed

639f7d5

ho-dor force-pushed the development branch from 65bac69 to 639f7d5 Compare May 30, 2019 12:31

neel1998 approved these changes May 30, 2019

View reviewed changes

CloudyPadmal merged commit a9701ac into fossasia:development May 30, 2019

CloudyPadmal assigned ho-dor May 30, 2019

ho-dor mentioned this pull request May 30, 2019

App crashed on Opening Thermometer #1752

Closed

neel1998 pushed a commit to neel1998/pslab-android that referenced this pull request Jul 30, 2019

Thermometer working added and crash fixed (fossasia#1754)

7d6bcde

Thermometer working added and crash fixed #1754

Thermometer working added and crash fixed #1754

Uh oh!

Conversation

ho-dor commented May 28, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

CloudyPadmal left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

neel1998 left a comment

Choose a reason for hiding this comment

Uh oh!

CloudyPadmal commented May 29, 2019

Uh oh!

CloudyPadmal commented May 29, 2019

Uh oh!

ho-dor commented May 29, 2019

Uh oh!

CloudyPadmal commented May 29, 2019

Uh oh!

ho-dor commented May 29, 2019

Uh oh!

Choose a reason for hiding this comment

Uh oh!

CloudyPadmal commented May 30, 2019

Uh oh!

neel1998 commented May 30, 2019

Uh oh!

ho-dor commented May 30, 2019

Uh oh!

ho-dor commented May 30, 2019

Uh oh!

ho-dor commented May 30, 2019

Uh oh!

neel1998 commented May 30, 2019

Uh oh!

ho-dor commented May 30, 2019

Uh oh!

neel1998 commented May 30, 2019

Uh oh!

ho-dor commented May 30, 2019

Uh oh!

neel1998 commented May 30, 2019

Uh oh!

ho-dor commented May 30, 2019

Uh oh!

neel1998 commented May 30, 2019

Uh oh!

ho-dor commented May 30, 2019

Uh oh!

neel1998 commented May 30, 2019

Uh oh!

ho-dor commented May 30, 2019

Uh oh!

neel1998 commented May 30, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

ho-dor commented May 28, 2019 •

edited

Loading