Thermometer settings added #1764
Conversation
|
@CloudyPadmal @neel1998 please review. |
| label_statAvg.setText(R.string.avg_thermo_fahrenheit); | ||
| label_statMax.setText(R.string.max_thermo_fahrenheit); | ||
| label_statMin.setText(R.string.min_thermo_fahrenheit); | ||
| thermometer.setUnit("F"); |
There was a problem hiding this comment.
Put the degree sign to this as well similar to C
| public static final String KEY_INCLUDE_LOCATION = "include_location_sensor_data"; | ||
| public static final String KEY_UPDATE_PERIOD = "setting_thermo_update_period"; | ||
| public static final String KEY_THERMO_SENSOR_TYPE = "setting_thermo_sensor_type"; | ||
| public static final String KEY_THERMO_SENSOR_GAIN = "setting_thermo_sensor_gain"; |
There was a problem hiding this comment.
We don't have a "Gain" for thermo sensor. Can remove this setting.
app/src/main/res/values/strings.xml
Outdated
| </string-array> | ||
|
|
||
| <string-array name="thermo_unit_list"> | ||
| <item>F</item> |
CloudyPadmal
added
the
Status: Review Required
|
@CloudyPadmal check |
|
@ho-dor when the user opens the configuration for the first time. No unit is shown in select unit preference. Please cet C as default. Also add space in the menu title "Thermometer Configuration" |
The menu title is actually consistent with all the other instruments. |
|
I have the updated the default unit value . Please check the updated apk. |
CloudyPadmal
removed
the
Status: Review Required
3 participants
Fixes #1756
Changes: Settings menu with the option to change units.
Screenshot/s for the changes:
Checklist: [Please tick following check boxes with
[x]if the respective task is completed]strings.xml,dimens.xmlandcolors.xmlwithout hard-coding themstrings.xml,dimens.xmlorcolors.xmlAPK for testing:
app-debug.zip